-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update script behavior section #6798
update script behavior section #6798
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
As for the broken link: It is mdx. You could replace the |
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
Thank you that's brilliant |
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
Sorry for the nitpicking. The main reason for the suggested changes are scripts like this:
which are module scripts (= deferred loading) but not bundled (instead inlined) and can be re-executed without problems. So much for: "scripts are run in sequential order"
(both are inline even though it is only explicit for the second one) |
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
I appreciate the nitpick especially when its as easy as hitting commit suggestions haha and I really do want this section of the docs to be as clear as possible because this is a huge part of the view tranistions experience haha at least running a module will run when its meant to (deffered) but yeah the whole any attribute creates is:inline is weird |
@sarah11918 Could you take another look at this when you get a chance? |
Yup! These 4.5 docs are on deck for this week! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OliverSpeir, just a few nits suggestions, after this it should be good to go 🙌
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Thank you! Great catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! Thanks for waiting patiently @OliverSpeir ! I went through this and think some restructuring of the content (both the original and yours) makes it even more helpful, so see whether my attempt makes sense here, and let me know what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 brilliant suggestions thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @OliverSpeir ! I really appreciate you adding the extra context over and above documenting astro-data-rerun
!
Description (required)
Reworks the Scripts section of
view-transitions.mdx
, relativey significantly. Adds documentation for new attribute of<script>
tagsdata-astro-rerun
Related PR
withastro/astro#9977
For Astro version:
4.5
Would love your review on this @martrapp