Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search result links by reintroducing URL hash #2075

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 20, 2022

What kind of changes does this PR include?

  • Changes to the docs site code

Description

#2071 introduced a bug where the hashes in links to search results were lost, meaning you’d always just jump to the top of pages. This fixes that!

@delucis delucis added the bug Something on the site isn't working label Nov 20, 2022
@netlify
Copy link

netlify bot commented Nov 20, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 13b9f0f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6379f87c51bb0c0008850597
😎 Deploy Preview https://deploy-preview-2075--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member Author

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging without review as I think this is pretty urgent for weekend users.

@delucis delucis merged commit 3281c29 into main Nov 20, 2022
@delucis delucis deleted the chris/fix-search-links branch November 20, 2022 11:54
@sarah11918
Copy link
Member

Thanks for this! We'll keep an eye on it throughout the day and update as needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something on the site isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants