Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3 checks] Astro.cookies existing examples #4276

Closed
sarah11918 opened this issue Aug 19, 2023 · 3 comments
Closed

[v3 checks] Astro.cookies existing examples #4276

sarah11918 opened this issue Aug 19, 2023 · 3 comments
Assignees
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) v3.0

Comments

@sarah11918
Copy link
Member

📚 Subject area/topic

Astro.cookies

📋 Page(s) affected (or suggested, for new content)

https://docs.astro.build/en/guides/server-side-rendering/#astrocookies ( line 227)
https://docs.astro.build/en/reference/api-reference/#astrocookies (line 206)
https://docs.astro.build/en/guides/backend/google-firebase/#creating-pages (lines 357, 434, 476)

📋 General description or bullet points (if proposing new content)

Need @matthewp to check these code examples and see whether anything needs updating for v3.0 in light of PR 7888 - Astro.cookies.get(key) will return undefined if the cookie does not exist.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

no reproduction

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) v3.0 labels Aug 19, 2023
@matthewp
Copy link
Contributor

One PR: #4302

@matthewp
Copy link
Contributor

That should be the only thing, the API docs are updated in next.

@sarah11918
Copy link
Member Author

Closed as completed! Thank you Matthew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) v3.0
Projects
None yet
Development

No branches or pull requests

2 participants