-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure appEntrypoint
is referenced in Vue components
#9490
Conversation
🦋 Changeset detectedLatest commit: 66ac8b1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nice! Thanks for the fix. Looked at the code but wouldn't be able to make sense of it without more study. Just double check that it works/errors consistently between dev and prod, as I think that's the most important thing 😇 |
!preview 9490 |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
@vincerubinetti You can help us confirm by trying this preview release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
02bb472
to
973d559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Changes
appEntrypoint
file..vue
component. It may not be the cleanest method, but this does allow Astro to associate styles referenced by theappEntrypoint
with pages where Vue components are rendered.Testing
New test suite added for dev and build behavior
Tested manually, too
Docs
N/A, bug fix only