Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip check for known Qwik components #9482

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Skip check for known Qwik components #9482

merged 2 commits into from
Dec 20, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Updates react, preact, and solid renderers to avoid check calls on Qwik components
  • Since all Qwik components have a name of QwikComponent, this check is very trivial to add to our renderers and improves compatibility for users
  • Related to Qwik and other JSX renderers in Astro QwikDev/astro#13

Testing

Tested manually with the Qwik integration + our integrations

No tests added because the Qwik integration isn't official

Docs

N/A

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 8e70feb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Dec 19, 2023
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natemoo-re natemoo-re merged commit 72b26da into main Dec 20, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/qwik-compat branch December 20, 2023 18:59
@astrobot-houston astrobot-houston mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants