Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move create-astro async tasks to end #9470

Merged
merged 8 commits into from
Jan 3, 2024

Conversation

onsclom
Copy link
Contributor

@onsclom onsclom commented Dec 19, 2023

Changes

Defer async actions until after user input to improve user experience. More details were discussed in this Astro Discord thread.

create-astro.mp4

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 5371bfc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 19, 2023
@jacobdalamb
Copy link
Contributor

Genius

@natemoo-re
Copy link
Member

This is great! We discussed this on Discord and I'm excited to get this reviewed as soon as we can.

I'd consider this a minor change, which means we likely won't merge and release until the start of the new year. Other than that, I'm sure folks will review as soon as they can!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, love the idea! Thanks for contributing.

Some tiny nits about how the labels are displayed, but I'm happy with this change overall. We'll definitely want to try this with the --yes and --no flags to make sure the UI still makes sense before a final approval.

packages/create-astro/src/index.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/typescript.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/template.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/git.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/dependencies.ts Outdated Show resolved Hide resolved
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@onsclom
Copy link
Contributor Author

onsclom commented Dec 22, 2023

This is great, love the idea! Thanks for contributing.

Some tiny nits about how the labels are displayed, but I'm happy with this change overall. We'll definitely want to try this with the --yes and --no flags to make sure the UI still makes sense before a final approval.

Thanks!

I think the UI looks great with --yes and --no too:

--yes

Before:

Screenshot 2023-12-22 at 10 13 18 AM

After:

Screenshot 2023-12-22 at 10 15 08 AM

--no

Before:

Screenshot 2023-12-22 at 10 15 53 AM

After:

Screenshot 2023-12-22 at 10 15 59 AM

@matthewp matthewp added the semver: minor Change triggers a `minor` release label Dec 27, 2023
.changeset/chatty-penguins-sin.md Outdated Show resolved Hide resolved
@Princesseuh Princesseuh added this to the 4.1.0 milestone Jan 2, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a delightful contribution, @onsclom! I've just left an idea for the changeset from docs because I think the changelog message could show off this feature a little better: let's make it as delightful as the feature itself! 🥳

.changeset/chatty-penguins-sin.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for suggesting this and getting the feature implemented! ❤️

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs is happy!

@ematipico ematipico merged commit 607303b into withastro:main Jan 3, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants