Fix getCollection when collection is empty #8642
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
getCollection
when the collection is empty.3.1.2
included #8382 which was meant to prevent an error from throwing, and replace it with a warning. The implementation instead returned an Astro integration fromgetCollection
. This PR removes that, and replaces it with aconsole.warn
before returning an empty array.Other options
undefined
if we want to explicitely show the collection does not exist.Testing
The previous PR had testing to confirm it was no longer throwing an error.
Docs
I need to check if docs need updating, but in any case the current behaviour is already undocumented. @Princesseuh did mention that the previous PR deprecated an error, so that will likely also need addressing.
/cc @withastro/maintainers-docs for feedback!