Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change functionPerRoute to false by default #8546

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Changes functionPerRoute
  • Reasons explained in the docs and changeset.

Testing

N/A

Docs

N/A

@matthewp matthewp requested a review from a team as a code owner September 13, 2023 18:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 94ab1e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 13, 2023
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @matthewp ! Just made some docs suggestions for your consideration! Take what you like!

packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
.changeset/cool-pianos-smell.md Outdated Show resolved Hide resolved
.changeset/cool-pianos-smell.md Outdated Show resolved Hide resolved
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the change but we might also want to call this out on the docs site? I guess we don't really do updates for integrations, but maybe we should.

matthewp and others added 4 commits September 13, 2023 17:46
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

Turn off `functionPerRoute` by default

In the previous version of `@astrojs/vercel`, the default for `functionPerRoute` was changed to `true`. While this option has several advantages, if you a free tier user you are likely to run into the limit of 12 functions per deployment. This will result in an error when you attempt to deploy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you you're a free

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this baby! 🛳️

@matthewp matthewp merged commit b79e11f into main Sep 14, 2023
13 checks passed
@matthewp matthewp deleted the flip-vercel-default branch September 14, 2023 12:15
@astrobot-houston astrobot-houston mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants