Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional scoping for head buffering #6152

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Add additional scoping for head buffering #6152

merged 11 commits into from
Feb 7, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 6, 2023

Changes

Testing

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

🦋 Changeset detected

Latest commit: f345900

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Feb 6, 2023
@matthewp
Copy link
Contributor Author

matthewp commented Feb 6, 2023

!preview mdx-links

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--mdx-links" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2mae034a3ba512e0f9�[0m �[34m@astrojs/prism:build: �[0mcache hit, suppressing output �[2m8a7a3e87405ac8aa�[0m �[35mcreate-astro:build: �[0mcache hit, suppressing output �[2m5f079ff0ef484f46�[0m �[33m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2ma5a809388eb2bdd5�[0m �[36m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m7d8cbc0b8550685c�[0m �[32mastro:build: �[0mcache miss, executing �[2m4d727d80ae5778ea�[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-mdx-links-20230206150400 build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-mdx-links-20230206150400 prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[35m@astrojs/lit:build: �[0mcache miss, executing �[2ma5eeb600d5eda3e0�[0m �[32m@astrojs/netlify:build: �[0mcache miss, executing �[2mb0c89c523d0366fe�[0m �[36m@astrojs/prefetch:build: �[0mcache miss, executing �[2mb7cbe633fbafdebd�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2m4a09f38f6cf7d70b�[0m �[36m@astrojs/react:build: �[0mcache miss, executing �[2ma98e49bcb9e76a45�[0m �[34m@astrojs/preact:build: �[0mcache miss, executing �[2m677904e8a861dde0�[0m �[33m@astrojs/rss:build: �[0mcache miss, executing �[2m4841a82937005a40�[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2m175dab1b5d51298e�[0m �[35m@astrojs/vercel:build: �[0mcache miss, executing �[2m831476c944b3e937�[0m �[32m@astrojs/deno:build: �[0mcache miss, executing �[2m516832b5fe0ebd02�[0m �[32m@astrojs/netlify:build: �[0m �[32m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.1.1 build /home/runner/work/astro/astro/packages/integrations/netlify �[32m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/netlify:build: �[0m �[35m@astrojs/lit:build: �[0m �[35m@astrojs/lit:build: �[0m> @astrojs/lit@1.1.2 build /home/runner/work/astro/astro/packages/integrations/lit �[35m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/lit:build: �[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.16.0 build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[36m@astrojs/prefetch:build: �[0m �[36m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.1.2 build /home/runner/work/astro/astro/packages/integrations/prefetch �[36m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/prefetch:build: �[0m �[36m@astrojs/react:build: �[0m �[36m@astrojs/react:build: �[0m> @astrojs/react@2.0.2 build /home/runner/work/astro/astro/packages/integrations/react �[36m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/react:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.0.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/rss:build: �[0m �[33m@astrojs/rss:build: �[0m> @astrojs/rss@2.1.0 build /home/runner/work/astro/astro/packages/astro-rss �[33m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/rss:build: �[0m �[34m@astrojs/preact:build: �[0m �[34m@astrojs/preact:build: �[0m> @astrojs/preact@2.0.2 build /home/runner/work/astro/astro/packages/integrations/preact �[34m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/preact:build: �[0m �[35m@astrojs/vercel:build: �[0m �[35m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.0.1 build /home/runner/work/astro/astro/packages/integrations/vercel �[35m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/vercel:build: �[0m �[32m@astrojs/deno:build: �[0m �[32m@astrojs/deno:build: �[0m> @astrojs/deno@4.0.0 build /home/runner/work/astro/astro/packages/integrations/deno �[32m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/deno:build: �[0m �[33m@astrojs/cloudflare:build: �[0mcache miss, executing �[2mbe07df4a95acdf06�[0m �[34m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m695f26d153b600fe�[0m �[36m@astrojs/svelte:build: �[0mcache miss, executing �[2m93713a74be45973e�[0m �[35m@astrojs/tailwind:build: �[0mcache miss, executing �[2mb3c337bf2d6414aa�[0m �[32m@astrojs/partytown:build: �[0mcache miss, executing �[2mb119a4a992e9b84a�[0m �[33m@astrojs/solid-js:build: �[0mcache miss, executing �[2mc531504a6e7cff81�[0m �[36m@astrojs/image:build: �[0mcache miss, executing �[2m1ccd8f9553a71362�[0m �[35m@astrojs/alpinejs:build: �[0mcache miss, executing �[2mc0306fda7d6588da�[0m �[33m@astrojs/cloudflare:build: �[0m �[33m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@0.0.0-mdx-links-20230206150400 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[33m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/cloudflare:build: �[0m �[34m@astrojs/turbolinks:build: �[0m �[34m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.1.5 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[34m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/turbolinks:build: �[0m �[32m@astrojs/node:build: �[0mcache miss, executing �[2m8a89b28ad398dcf3�[0m �[36m@astrojs/svelte:build: �[0m �[36m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte �[36m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[36m@astrojs/svelte:build: �[0m �[35m@astrojs/tailwind:build: �[0m �[35m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.0.1 build /home/runner/work/astro/astro/packages/integrations/tailwind �[35m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/tailwind:build: �[0m �[32m@astrojs/partytown:build: �[0m �[32m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.0.3 build /home/runner/work/astro/astro/packages/integrations/partytown �[32m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/partytown:build: �[0m �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.0.2 build /home/runner/work/astro/astro/packages/integrations/solid �[33m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/solid-js:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.0 build /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[36m@astrojs/image:build: �[0m �[33m@astrojs/vue:build: �[0mcache miss, executing �[2ma7a87dace72ed8e6�[0m �[35m@astrojs/alpinejs:build: �[0m �[35m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.1.3 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[35m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/alpinejs:build: �[0m �[32m@astrojs/node:build: �[0m �[32m@astrojs/node:build: �[0m> @astrojs/node@5.0.3 build /home/runner/work/astro/astro/packages/integrations/node �[32m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/node:build: �[0m �[33m@astrojs/vue:build: �[0m �[33m@astrojs/vue:build: �[0m> @astrojs/vue@2.0.1 build /home/runner/work/astro/astro/packages/integrations/vue �[33m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[33m@astrojs/vue:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.0 postbuild /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[36m@astrojs/image:build: �[0m Tasks: 26 successful, 26 total Cached: 5 cached, 26 total Time: 1m2.844s Package �[36m"@astrojs/markdown-remark"�[39m must depend on the current version of �[36m"astro"�[39m: �[32m"0.0.0-mdx-links-20230206150400"�[39m vs �[31m"^2.0.2"�[39m 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--mdx-links tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-mdx-links-20230206150400) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.1.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.3 is already published on npm 🦋 �[36minfo�[39m @astrojs/cloudflare is being published because our local version (0.0.0-mdx-links-20230206150400) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.14.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.16.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.0.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-mdx-links-20230206150400"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/cloudflare"�[39m at �[32m"0.0.0-mdx-links-20230206150400"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-mdx-links-20230206150400 🦋 @astrojs/cloudflare@0.0.0-mdx-links-20230206150400 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-mdx-links-20230206150400 🦋 New tag: @astrojs/cloudflare@0.0.0-mdx-links-20230206150400

@matthewp
Copy link
Contributor Author

matthewp commented Feb 6, 2023

!preview mdx-links

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--mdx-links" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2m557eff2889fcddd6�[0m �[33m@astrojs/prism:build: �[0mcache hit, suppressing output �[2m4c84f02753537eb8�[0m �[34m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m0700a4c03f4d6f60�[0m �[35m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2mf4f599d28d2fd1d7�[0m �[32mastro:build: �[0mcache miss, executing �[2m015f33a4f9bf9b4f�[0m �[36mcreate-astro:build: �[0mcache miss, executing �[2m145fb315f95ed575�[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-mdx-links-20230206172907 build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[36mcreate-astro:build: �[0m �[36mcreate-astro:build: �[0m> create-astro@0.0.0-mdx-links-20230206172907 build /home/runner/work/astro/astro/packages/create-astro �[36mcreate-astro:build: �[0m> astro-scripts build "src/index.ts" --bundle && tsc �[36mcreate-astro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-mdx-links-20230206172907 prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[32m@astrojs/alpinejs:build: �[0mcache miss, executing �[2m10c2120bf5b234e2�[0m �[32m@astrojs/vercel:build: �[0mcache miss, executing �[2mfeb61fc899a8c873�[0m �[33m@astrojs/rss:build: �[0mcache miss, executing �[2m8c97a8d4d926e405�[0m �[34m@astrojs/vue:build: �[0mcache miss, executing �[2mee14e9e9e616bec0�[0m �[33m@astrojs/partytown:build: �[0mcache miss, executing �[2m563b1acdcfbe3b71�[0m �[36m@astrojs/image:build: �[0mcache miss, executing �[2mbced440dcd9d282c�[0m �[34m@astrojs/prefetch:build: �[0mcache miss, executing �[2mcb7f048ff175f6c7�[0m �[36m@astrojs/sitemap:build: �[0mcache miss, executing �[2m125df7ea53f81d0f�[0m �[35m@astrojs/tailwind:build: �[0mcache miss, executing �[2m03ccff2992884827�[0m �[35m@astrojs/mdx:build: �[0mcache miss, executing �[2m34874b13c7dbaf33�[0m �[32m@astrojs/vercel:build: �[0m �[32m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.0.1 build /home/runner/work/astro/astro/packages/integrations/vercel �[32m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/vercel:build: �[0m �[32m@astrojs/alpinejs:build: �[0m �[32m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.1.3 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[32m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/alpinejs:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.0 build /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[36m@astrojs/image:build: �[0m �[34m@astrojs/prefetch:build: �[0m �[34m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.1.2 build /home/runner/work/astro/astro/packages/integrations/prefetch �[34m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/prefetch:build: �[0m �[33m@astrojs/partytown:build: �[0m �[33m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.0.3 build /home/runner/work/astro/astro/packages/integrations/partytown �[33m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/partytown:build: �[0m �[33m@astrojs/rss:build: �[0m �[33m@astrojs/rss:build: �[0m> @astrojs/rss@2.1.0 build /home/runner/work/astro/astro/packages/astro-rss �[33m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/rss:build: �[0m �[34m@astrojs/vue:build: �[0m �[34m@astrojs/vue:build: �[0m> @astrojs/vue@2.0.1 build /home/runner/work/astro/astro/packages/integrations/vue �[34m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[34m@astrojs/vue:build: �[0m �[35m@astrojs/tailwind:build: �[0m �[35m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.0.1 build /home/runner/work/astro/astro/packages/integrations/tailwind �[35m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/tailwind:build: �[0m �[36m@astrojs/sitemap:build: �[0m �[36m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.0.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[36m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/sitemap:build: �[0m �[35m@astrojs/mdx:build: �[0m �[35m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.16.0 build /home/runner/work/astro/astro/packages/integrations/mdx �[35m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/mdx:build: �[0m �[33m@astrojs/cloudflare:build: �[0mcache miss, executing �[2m4e326ca0ccb0a43f�[0m �[34m@astrojs/netlify:build: �[0mcache miss, executing �[2m39d97f1c7a2163c5�[0m �[36m@astrojs/react:build: �[0mcache miss, executing �[2ma1609d38688d9d3f�[0m �[35m@astrojs/node:build: �[0mcache miss, executing �[2m9bc9f373e6268342�[0m �[32m@astrojs/solid-js:build: �[0mcache miss, executing �[2m379f773e3a7187df�[0m �[33m@astrojs/cloudflare:build: �[0m �[33m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@0.0.0-mdx-links-20230206172907 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[33m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/cloudflare:build: �[0m �[34m@astrojs/preact:build: �[0mcache miss, executing �[2m2eb62f7a643606bc�[0m �[36m@astrojs/deno:build: �[0mcache miss, executing �[2m61786291e6e8f1f2�[0m �[34m@astrojs/netlify:build: �[0m �[34m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.1.1 build /home/runner/work/astro/astro/packages/integrations/netlify �[34m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/netlify:build: �[0m �[35m@astrojs/node:build: �[0m �[35m@astrojs/node:build: �[0m> @astrojs/node@5.0.3 build /home/runner/work/astro/astro/packages/integrations/node �[35m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/node:build: �[0m �[36m@astrojs/react:build: �[0m �[36m@astrojs/react:build: �[0m> @astrojs/react@2.0.2 build /home/runner/work/astro/astro/packages/integrations/react �[36m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/react:build: �[0m �[32m@astrojs/solid-js:build: �[0m �[32m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.0.2 build /home/runner/work/astro/astro/packages/integrations/solid �[32m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/solid-js:build: �[0m �[35m@astrojs/lit:build: �[0mcache miss, executing �[2m8edb303d505cdddb�[0m �[36m@astrojs/deno:build: �[0m �[36m@astrojs/deno:build: �[0m> @astrojs/deno@4.0.0 build /home/runner/work/astro/astro/packages/integrations/deno �[36m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/deno:build: �[0m �[34m@astrojs/preact:build: �[0m �[34m@astrojs/preact:build: �[0m> @astrojs/preact@2.0.2 build /home/runner/work/astro/astro/packages/integrations/preact �[34m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/preact:build: �[0m �[32m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m1f4f1e6277be094b�[0m �[35m@astrojs/lit:build: �[0m �[35m@astrojs/lit:build: �[0m> @astrojs/lit@1.1.2 build /home/runner/work/astro/astro/packages/integrations/lit �[35m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/lit:build: �[0m �[32m@astrojs/turbolinks:build: �[0m �[32m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.1.5 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[32m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/turbolinks:build: �[0m �[33m@astrojs/svelte:build: �[0mcache miss, executing �[2mfbce98038e2a3679�[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.0 postbuild /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[36m@astrojs/image:build: �[0m �[33m@astrojs/svelte:build: �[0m �[33m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte �[33m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[33m@astrojs/svelte:build: �[0m Tasks: 26 successful, 26 total Cached: 4 cached, 26 total Time: 1m9.691s Package �[36m"@astrojs/markdown-remark"�[39m must depend on the current version of �[36m"astro"�[39m: �[32m"0.0.0-mdx-links-20230206172907"�[39m vs �[31m"^2.0.2"�[39m 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--mdx-links tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-mdx-links-20230206172907) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.1.0 is already published on npm 🦋 �[36minfo�[39m create-astro is being published because our local version (0.0.0-mdx-links-20230206172907) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.3 is already published on npm 🦋 �[36minfo�[39m @astrojs/cloudflare is being published because our local version (0.0.0-mdx-links-20230206172907) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.14.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.16.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.0.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-mdx-links-20230206172907"�[39m 🦋 �[36minfo�[39m Publishing �[36m"create-astro"�[39m at �[32m"0.0.0-mdx-links-20230206172907"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/cloudflare"�[39m at �[32m"0.0.0-mdx-links-20230206172907"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-mdx-links-20230206172907 🦋 create-astro@0.0.0-mdx-links-20230206172907 🦋 @astrojs/cloudflare@0.0.0-mdx-links-20230206172907 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-mdx-links-20230206172907 🦋 New tag: create-astro@0.0.0-mdx-links-20230206172907 🦋 New tag: @astrojs/cloudflare@0.0.0-mdx-links-20230206172907

packages/astro/package.json Outdated Show resolved Hide resolved
@matthewp matthewp marked this pull request as ready for review February 6, 2023 22:38
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the changes, I think I understood the flow roughly 80%, but checking the logic I don't see anything incorrect, so putting an approval from me!

@matthewp
Copy link
Contributor Author

matthewp commented Feb 7, 2023

@bluwy let me explain the flow for future readers then:

  1. When calling JSX, Slots, head buffering (used to know what CSS to propagate), and slots.render(), append bit flags to result.scope.
  2. Also created a scoped version of the result object (ie, Object.create(result)) so we can "lock in" result.scope so it applies only to children and not siblings.
  3. In maybeRenderHead logic, use the bit flags to determine if we should render the head. The idea is that there are known scenarios where we should not; for example inside of a slot that's inside of JSX.

This all became necessary because of a combination of:

  1. Implicit head injection.
  2. Content collections and head propagation.

This code works but does add some bloat to the codebase that would be great to get rid of. For that reason I'm going to create a proposal that removes implicit head injection (likely in combination with a new feature like head propagation).

@matthewp matthewp merged commit d1f5611 into main Feb 7, 2023
@matthewp matthewp deleted the mdx-bleed2 branch February 7, 2023 15:56
@astrobot-houston astrobot-houston mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
2 participants