-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use the root of the project as the functions location #6075
fix: use the root of the project as the functions location #6075
Conversation
🦋 Changeset detectedLatest commit: 6a88eba The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
477b9e8
to
15ccdda
Compare
I need help with the tests here. The fixture doesn't seem to work correctly when creating the functions folder, and the previous tests were naive. |
I assume the problem is with using relative paths in the test, right? Those are defined here: https://github.com/withastro/astro/blob/main/packages/astro/test/test-utils.js#L168-L171 if it helps with debugging. |
Part of the problem is that the functions folder is not being created when I read the elements of the folder in the But that helps, thank you! |
31bb236
to
cd25d60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being picky 😄
Thanks for being picky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more :)
219637b
to
85de8ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thank you for making Astro better!
Thanks for your help!!! |
Hi @AirBorne04 , sorry to bother you, but do you have any info about when the next release of the Cloudflare adapter will happen? I need this changes :) thank you! |
Nevermind, I think it is out already! Thank you! |
Changes
directory
mode.Fixes: #6066
Testing
Test the location of the functions folder creation.
Docs
Docs don't need to be updated, docs already state that the root of the project is the place to generate the functions folder.