Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lit] Forwards compatiblity for streaming Declarative Shadow DOM #6055

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented Jan 31, 2023

Changes

  • Adds forwards compat for DSD
  • Context
  • Renders DSD templates with both the soon-to-be legacy shadowroot attribute and the shadowrootmode attribute
  • This change to the spec is happening in Safari TP and Chrome 111

Testing

Tests will continue to pass in Chrome 111 and Safari

Updated tests to reflect new expected templates

Docs

This is an implementation detail that doesn't need to be surfaced to the user.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023

🦋 Changeset detected

Latest commit: 30337c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@e111077 e111077 changed the title Forwards compatiblity for streaming DSD [Lit] Forwards compatiblity for streaming Declarative Shadow DOM Jan 31, 2023
@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels Jan 31, 2023
@matthewp
Copy link
Contributor

matthewp commented Feb 1, 2023

Wow, I didn't realize they were changing this attribute name. A bit unfortunate. Thanks for the context!

@matthewp matthewp merged commit 2567aa4 into withastro:main Feb 1, 2023
@astrobot-houston astrobot-houston mentioned this pull request Feb 1, 2023
matthewp pushed a commit that referenced this pull request Feb 3, 2023
* Forwards compatiblity for streaming DSD

* add shadowrootmode

* update tests

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants