Handle getStaticPaths with prerendered pages
#5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 369ac8b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Please... someone to merge this PR??? Thanks |
bholmesdev
reviewed
Jan 4, 2023
|
@juanmiguelguerrero We will certainly merge soon! We have a request-for-review channel on our discord (#dev-ptal) for maintainers to review when they're available. Excited to get this one in! |
natemoo-re
force-pushed
the
fix/prerender-dynamic
branch
from
9865539
to
c24a186
Compare
bholmesdev
approved these changes
Jan 4, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getStaticPathswas not validated or handled properly forprerendered pages. This PR updates ourgetStaticPathslogic and some build logic to account for this case.Testing
getStaticPathstests ported to testprerendersupport as wellDocs
Error message updated to callout this case.