Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle getStaticPaths with prerendered pages #5734

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jan 3, 2023

Changes

  • Closes Experimental prerender does not work for dynamic routes #5661
  • Previously, getStaticPaths was not validated or handled properly for prerendered pages. This PR updates our getStaticPaths logic and some build logic to account for this case.
  • Before: no error message during dev, irrelevant error message during build.
  • After: clear error message during dev, same error message during build.

Testing

getStaticPaths tests ported to test prerender support as well

Docs

Error message updated to callout this case.

@natemoo-re natemoo-re requested a review from a team as a code owner January 3, 2023 21:17
@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2023

🦋 Changeset detected

Latest commit: 369ac8b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 3, 2023
@juanmiguelguerrero
Copy link
Contributor

Please... someone to merge this PR???

Thanks

@sarah11918 sarah11918 removed the request for review from a team January 4, 2023 16:10
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on testing, but this has pre-rendered me speechless 😶

@bholmesdev
Copy link
Contributor

@juanmiguelguerrero We will certainly merge soon! We have a request-for-review channel on our discord (#dev-ptal) for maintainers to review when they're available. Excited to get this one in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental prerender does not work for dynamic routes
3 participants