Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change path into assets #5584

Merged
merged 7 commits into from
Jan 5, 2023
Merged

feat: change path into assets #5584

merged 7 commits into from
Jan 5, 2023

Conversation

JerryWu1234
Copy link
Contributor

Changes

fix bug #5502

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

🦋 Changeset detected

Latest commit: f48ccdf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Dec 12, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wulinsheng123! I’ll leave it to more expert eyes to review this properly.

.changeset/lovely-worms-invite.md Show resolved Hide resolved
@delucis delucis added the semver: major Change triggers a `major` release label Dec 21, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until Astro v2. Needs major changesets as suggested by @bluwy.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! We decided to do an additional change and output to an _astro directory instead of assets, but I can make that change on top of these.

Many thanks for the PR!

@bluwy
Copy link
Member

bluwy commented Jan 5, 2023

@natemoo-re maybe we should make those changes directly in this PR so we have one changeset that doesn't mention this intermediate change 🤔

@natemoo-re
Copy link
Member

@bluwy I was going to do that, but I think my changes will be quite involved. I'll be sure to update the changelog in my PR as well.

@natemoo-re natemoo-re merged commit 9963c6e into withastro:main Jan 5, 2023
@JerryWu1234 JerryWu1234 deleted the chunk branch January 11, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: major Change triggers a `major` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants