-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change path into assets #5584
Conversation
🦋 Changeset detectedLatest commit: f48ccdf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wulinsheng123! I’ll leave it to more expert eyes to review this properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until Astro v2. Needs major changesets as suggested by @bluwy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! We decided to do an additional change and output to an _astro
directory instead of assets
, but I can make that change on top of these.
Many thanks for the PR!
@natemoo-re maybe we should make those changes directly in this PR so we have one changeset that doesn't mention this intermediate change 🤔 |
4a1eeca
to
f48ccdf
Compare
@bluwy I was going to do that, but I think my changes will be quite involved. I'll be sure to update the changelog in my PR as well. |
Changes
fix bug #5502
Testing
Docs