Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image test fail #5321

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix image test fail #5321

merged 1 commit into from
Nov 8, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 8, 2022

Changes

Fix failing test in main currently caused by #5290.

There's a image test not handled for the new base handling.

Testing

Should pass

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

⚠️ No Changeset found

Latest commit: fe5c3c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 8, 2022
@matthewp
Copy link
Contributor

matthewp commented Nov 8, 2022

Thanks!

@matthewp matthewp merged commit 7f3b039 into main Nov 8, 2022
@matthewp matthewp deleted the fix-test-fail branch November 8, 2022 13:31
matthewp pushed a commit that referenced this pull request Nov 8, 2022
@bluwy @matthewp
Fix image test fail (#5321)
3bcc3b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @matthewp