Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 404 routing logic to Netlify redirects file #4274

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Add 404 routing logic to Netlify redirects file #4274

merged 2 commits into from
Aug 11, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Produces this example _redirects:

  /    /.netlify/functions/entry    200
  /404    /.netlify/functions/entry    200
  /*    /.netlify/functions/entry    404

Testing

  • Test added to check the redirects file.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 176e8dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 11, 2022
@irg1008
Copy link

irg1008 commented Aug 11, 2022

Awesome!

FredKSchott
FredKSchott approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging so that we can get this out in the next release

@FredKSchott FredKSchott merged commit d3d09a2 into main Aug 11, 2022
@FredKSchott FredKSchott deleted the netlify-404 branch August 11, 2022 23:26
@astrobot-houston astrobot-houston mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom 404 with Astro SSR not working on Netlify
4 participants
@matthewp @irg1008 @FredKSchott @natemoo-re