Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Update Cloudflare README #4232

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

Ekwuno
Copy link
Contributor

@Ekwuno Ekwuno commented Aug 10, 2022

Changes

  • What does this change?
    This PR adds more context to how local development works with Wrangler and fixes spelling for middleware :)
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

This affects the GitHub readme only

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: 2b97943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 10, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Ekwuno
Copy link
Contributor Author

Ekwuno commented Aug 10, 2022

@natemoo-re I have another one open withastro/docs#1254 👀

@natemoo-re
Copy link
Member

Awesome, @Ekwuno! Really appreciate it. I'm going to merge this change and we can track the docs PR separately.

@natemoo-re natemoo-re merged commit bfbd325 into withastro:main Aug 10, 2022
@astrobot-houston astrobot-houston mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants