-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preact compat support for libraries #4213
Conversation
🦋 Changeset detectedLatest commit: ed5f91c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks @bluwy! We do want to continue to pin vite versions for a little while, so no Also needs a changeset. |
My bad. Added changesets and pinned Vite to 3.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're holding off on merging new PRs as 1.0 is coming out. Will approve after that is out and we're ready for merges again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge now, thanks!
Changes
Fix #4093
Fix #4107
compat: true
nownoExternal
-ize all react entrypoints so Vite can process and alias them to preact compat^3.0.5
to bring in a fix from fix(ssr): use appendRight for import vitejs/vite#9554Testing
Added
preact-compat-component
test fixture toastro/test
, and a sub package@test/react-lib
to emulate a React library to be usingpreact/compat
instead.Docs
N/A