Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier-plugin-astro to the monorepo #4083

Merged
merged 6 commits into from
Aug 6, 2022
Merged

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jul 28, 2022

Changes

Add our Prettier plugin to our Prettier config. This will run in CI on every .astro files in the repo (apart from fixtures)

A lot of issues in our Prettier plugin have been fixed since the last attempt at adding it, however due to two compiler issues (withastro/compiler#485, withastro/compiler#318) four files had to be ignored for now

Testing

Tested manually, but not really relevant

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

⚠️ No Changeset found

Latest commit: 16a5a0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -28,15 +28,13 @@
"version": "changeset version && pnpm install --no-frozen-lockfile && pnpm run format"
},
"workspaces": [
"compiled/*",
Copy link
Member Author

@Princesseuh Princesseuh Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier doesn't like that those folders don't exist, it instantly crashes with an error that the folder doesn't exist when plugins are enabled.

I tried ignoring those folders and disabling automatic plugin search, but that didn't solve the issue. I saw a few issues on their repo about this (notably a lot of people talking about MongoDB and Docker folders not existing)

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 28, 2022
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Aug 4, 2022
@Princesseuh Princesseuh changed the title [WIP] Add prettier-plugin-astro to the monorepo Add prettier-plugin-astro to the monorepo Aug 4, 2022
@Princesseuh Princesseuh marked this pull request as ready for review August 4, 2022 18:46
@Princesseuh Princesseuh self-assigned this Aug 5, 2022
@FredKSchott
Copy link
Member

I ran format and checked the entire diff, and everything looked good! I'm going to merge so that we get some more time with these changes in the monorepo before v1.0.0 release

@FredKSchott FredKSchott merged commit 24c8e7d into main Aug 6, 2022
@FredKSchott FredKSchott deleted the add-prettier-plugin branch August 6, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants