-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier-plugin-astro
to the monorepo
#4083
Conversation
|
@@ -28,15 +28,13 @@ | |||
"version": "changeset version && pnpm install --no-frozen-lockfile && pnpm run format" | |||
}, | |||
"workspaces": [ | |||
"compiled/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier doesn't like that those folders don't exist, it instantly crashes with an error that the folder doesn't exist when plugins are enabled.
I tried ignoring those folders and disabling automatic plugin search, but that didn't solve the issue. I saw a few issues on their repo about this (notably a lot of people talking about MongoDB and Docker folders not existing)
prettier-plugin-astro
to the monorepoprettier-plugin-astro
to the monorepo
This reverts commit 5536c51.
f251a5a
to
16a5a0a
Compare
I ran |
Changes
Add our Prettier plugin to our Prettier config. This will run in CI on every
.astro
files in the repo (apart from fixtures)A lot of issues in our Prettier plugin have been fixed since the last attempt at adding it, however due to two compiler issues (withastro/compiler#485, withastro/compiler#318) four files had to be ignored for now
Testing
Tested manually, but not really relevant
Docs
N/A