Support custom vue compiler options in @astrojs/vue #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfaddf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
tony-sull
changed the title
|
Can I just say that I'm SO EXCITED that we can support this now? ... can you do Svelte next :) It would be great to match this API: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/config.md |
|
Also curious how much of this we should support as well: https://www.npmjs.com/package/@vitejs/plugin-vue Edit: Oh wait, we literally support all of it, fantastic :) |
FredKSchott
approved these changes
Apr 19, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* adds support for passing options to @vitejs/plugin-vue * updating vue integration README with options details * adding a tests for custom vue compiler options * chore: adding changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This updates the the Vue integration to support passing options through to
@vitejs/plugin-vueTesting
Updated the
vue-componenttest with a custom element + Vue config to ignore component resolution for that tagDocs
Updated the integration README