-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a verbose flag to create-astro #2429
Conversation
🦋 Changeset detectedLatest commit: d1053fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 5e98dc1 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e9740c8861360007326cdf 😎 Browse the preview: https://deploy-preview-2429--astro-docs-2.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this will surely come in handy for all the WSL users 😉
const extractedLocale = process.env.LANG.split('.')[0].replace(/_/g, '-'); | ||
// Check if language code is atleast two characters long (ie. en, es). | ||
// NOTE: if "c" locale is encountered, the default locale will be returned. | ||
if (extractedLocale.length < 2) return defaultLocale; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really sure, this code is just a straight copy of the logger implemented in astro core but with some parts removed that didn't seem necessary for create-astro
, but I don't think that it would return anything like that, I am not very familiar with env variables though so I don't actually know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
Make if statement easier to read Co-authored-by: Evan Boehs <evan@boehs.org>
Changes
Testing
Docs