Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): add support vue devtools options #11055

Merged

Conversation

niklas-wortmann
Copy link
Contributor

@niklas-wortmann niklas-wortmann commented May 15, 2024

Changes

  • Vue Devtools support a launchEditor for "open in Editor"
  • This accepts the option and forwards it to the vue dev tools

Testing

  • no Idea how :D
  • more than happy to add a test with some guidance

Docs

Would probably make sense to update this section in the docs, happy to file a separate pr
/cc @withastro/maintainers-docs for feedback!

withastro/docs#8295

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 9f1f54a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels May 15, 2024
@florian-lefebvre florian-lefebvre self-requested a review May 16, 2024 06:36
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! A few things:

  • I added a few suggestions after @webfansplz comment
  • Testing manually is definitely fine!
  • Don't forget to add a changeset by running pnpm changeset (should be a minor I think)
  • It will require a docs PR, feel free to ping me on the associated PR!

packages/integrations/vue/src/index.ts Outdated Show resolved Hide resolved
packages/integrations/vue/src/index.ts Outdated Show resolved Hide resolved
packages/integrations/vue/src/index.ts Outdated Show resolved Hide resolved
@niklas-wortmann
Copy link
Contributor Author

I wasn't sure about the changeset thing, other than that it should be fine now

@florian-lefebvre
Copy link
Member

florian-lefebvre commented May 16, 2024

Awesome thanks! I updated the changeset, can you make a docs PR? You can take inspiration from the changeset if that helps you!

@Princesseuh
Copy link
Member

Princesseuh commented May 16, 2024

Seems like something happened in the lockfile, there's a lot of unrelated changes, could you fix that?

florian-lefebvre and others added 2 commits May 16, 2024 17:41
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
@niklas-wortmann
Copy link
Contributor Author

Thanks @florian-lefebvre for cleaning up after me 😬

@florian-lefebvre florian-lefebvre changed the title feat(vue): add support for launchEditor in devtools feat(vue): add support vue devtools options May 22, 2024
@florian-lefebvre florian-lefebvre merged commit b92de22 into withastro:main May 22, 2024
5 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants