Ensure --force-reset drops previous tables #10506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ba223a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FredKSchott
reviewed
Mar 20, 2024
| // When doing a reset, first create DROP TABLE statements, then treat everything | ||
| // else as creation. | ||
| if(reset) { | ||
| const curSnapshot = oldSnapshot; |
There was a problem hiding this comment.
actually, this name is a bit confusing, since it's not really the current snapshot right? Maybe like originalOldSnapshot?
FredKSchott
reviewed
Mar 20, 2024
| }): Promise<{ queries: string[]; confirmations: string[] }> { | ||
| const queries: string[] = []; | ||
| let queries: string[] = []; |
There was a problem hiding this comment.
nit: can we keep this as a const, and instead of overwriting the array do queries.push(...getDropTableQueriesForSnapshot(curSnapshot))? My fear is that future devs blow away existing queries accidentally by re-assigning
FredKSchott
reviewed
Mar 20, 2024
| ]); | ||
| }); | ||
|
|
||
| it('should not drop table when previous snapshot did not have it', async () => { |
FredKSchott
approved these changes
Mar 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--force-resetdid not include DROP TABLE statementsTesting
Docs
N/A, bug fix