Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer getting app token from runtime env #10445

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Use the runtime process.env.ASTRO_STUDIO_APP_TOKEN before falling back to one that's in CI.

Testing

  • manually

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: e69bca9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, .env files are often not included during docker/CI builds.

@matthewp matthewp merged commit 098623c into main Mar 14, 2024
13 checks passed
@matthewp matthewp deleted the app-token-check-env branch March 14, 2024 18:53
@astrobot-houston astrobot-houston mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants