Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove runtime/config suggestion for db config exports #10391

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

Before, your LSP would recommend importing defineDb() from @astrojs/runtime/config before recommending astro:db. This change removes runtime/config from public types to only surface astro:db

Testing

Manual pnpm link to check intellisense

Docs

N/A

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 972a828

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bholmesdev
Copy link
Contributor Author

!preview db-config-types

Copy link
Contributor

Snapshots have been released for the following packages:

  • @astrojs/db@experimental--db-config-types
Publish Log
🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--db-config-types tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  warn astro is not being published because version 4.5.0 is already published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.5 is already published on npm
🦋  warn create-astro is not being published because version 4.7.4 is already published on npm
🦋  info @astrojs/db is being published because our local version (0.0.0-db-config-types-20240311182802) has not been published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.0 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.9.2 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 2.2.0 is already published on npm
🦋  warn @astrojs/node is not being published because version 8.2.3 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.4 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.1.0 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.2.0 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 7.3.6 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.8 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.3.0 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.3.0 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.3 is already published on npm
🦋  info Publishing "@astrojs/db" at "0.0.0-db-config-types-20240311182802"
🦋  success packages published successfully:
🦋  @astrojs/db@0.0.0-db-config-types-20240311182802
🦋  Creating git tag...
🦋  New tag:  @astrojs/db@0.0.0-db-config-types-20240311182802
Build Log

> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 27 packages
• Remote caching enabled
::group::@astrojs/upgrade:build
cache hit, suppressing logs 9fd927bc35c512ad
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs fee99ffe53b3c0b8
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs fe17a029fab1f081
::endgroup::
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs a4c33c2aef00b0a7
::endgroup::
::group::create-astro:build
cache hit, suppressing logs 621710dcce869fe4
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs c64e42fb5c5d02ec
::endgroup::
::group::astro:build
cache hit, suppressing logs abbc13cb8c79f987
::endgroup::
::group::@astrojs/preact:build
cache hit, suppressing logs 69bbe1e62ce4b61d
::endgroup::
::group::@astrojs/svelte:build
cache hit, suppressing logs 4d112a3d0c03ef0a
::endgroup::
::group::@astrojs/underscore-redirects:build
cache hit, suppressing logs 0629eb83d45803c7
::endgroup::
::group::@astrojs/lit:build
cache hit, suppressing logs 5fa529b2f593afd4
::endgroup::
::group::@benchmark/timer:build
cache hit, suppressing logs 7f653ba75d5de4be
::endgroup::
::group::@astrojs/solid-js:build
cache hit, suppressing logs 941d5f93297cc049
::endgroup::
::group::@astrojs/mdx:build
cache hit, suppressing logs b945c6c39757a158
::endgroup::
::group::@astrojs/vercel:build
cache hit, suppressing logs c5fd239c40f04f71
::endgroup::
::group::@astrojs/partytown:build
cache hit, suppressing logs 6096609624c98fb7
::endgroup::
::group::@astrojs/tailwind:build
cache hit, suppressing logs 4a8c92d4cb72da79
::endgroup::
::group::@astrojs/markdoc:build
cache hit, suppressing logs 28dc2c8ad303daa5
::endgroup::
::group::@astrojs/node:build
cache hit, suppressing logs db63e69e82cd883f
::endgroup::
::group::@astrojs/alpinejs:build
cache hit, suppressing logs 667055b9382b2a11
::endgroup::
::group::@astrojs/rss:build
cache hit, suppressing logs 576242e82d390e35
::endgroup::
::group::@astrojs/react:build
cache hit, suppressing logs ca8bf5e334614509
::endgroup::
::group::@astrojs/sitemap:build
cache hit, suppressing logs 2125d6d1807748aa
::endgroup::
::group::@astrojs/vue:build
cache hit, suppressing logs f237141eb4420319
::endgroup::
::group::@astrojs/db:build
cache miss, executing 6fa50e0390c82a06

> @astrojs/db@0.0.0-db-config-types-20240311182802 build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    25 successful, 25 total
Cached:    24 cached, 25 total
  Time:    7.065s 

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 9667ee9 into main Mar 11, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/db-config-types branch March 11, 2024 19:44
@astrobot-houston astrobot-houston mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants