-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integrations API for db config/seed files #10321
Conversation
🦋 Changeset detectedLatest commit: 6f6593b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will astro db be part of core eventually or remain as a separate integration? |
The goal would be for it to eventually be part of core, but we still have several things to work out before that's ready, so it's going to remain an integration for the near future at least. |
@delucis can you explain why this needs to be a separate hook? I'm not against it, per se, but would like to understand the technical reasons for it. |
The main issue is that
That said, I think ideally this PR wouldn't make the types change included here. Will pick it up in the morning. |
b66ec9e
to
ecd69ac
Compare
API overall looks good to me. Could see some adjustment in the future but not anything important enough to do now. |
This reverts commit ef2156e.
!preview db-integrations-support |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview db-integrations-support |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Changes
astro:db:setup
hook. This hook provides anextendDb()
method to register the extra entrypoints.defineDbIntegration()
helper to get typing support.Testing
Docs