Add integrations API for db config/seed files #10321

delucis · 2024-03-04T15:48:48Z

Changes

Adds support for integrations adding db config and seed files via an astro:db:setup hook. This hook provides an extendDb() method to register the extra entrypoints.
The hook is not typed in Astro core yet. Integration authors should use a defineDbIntegration() helper to get typing support.

Testing

Added a fixture that tests an integration. It’s a local “in-project integration”, so I also manually tested locally with a separate packed integration with npm-style module identifier.

Docs

First pass in the changeset, will liaise with @sarah11918 about getting this into the actual docs

changeset-bot · 2024-03-04T15:48:53Z

🦋 Changeset detected

Latest commit: 6f6593b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

florian-lefebvre · 2024-03-04T16:35:50Z

Will astro db be part of core eventually or remain as a separate integration?

matthewp · 2024-03-04T20:20:26Z

@florian-lefebvre

Will astro db be part of core eventually or remain as a separate integration?

The goal would be for it to eventually be part of core, but we still have several things to work out before that's ready, so it's going to remain an integration for the near future at least.

matthewp · 2024-03-04T20:21:02Z

@delucis can you explain why this needs to be a separate hook? I'm not against it, per se, but would like to understand the technical reasons for it.

delucis · 2024-03-04T22:51:00Z

@delucis can you explain why this needs to be a separate hook? I'm not against it, per se, but would like to understand the technical reasons for it.

The main issue is that astro db has components that run outside of the usual Astro environment — primarily its dedicated CLI commands — that need to access the tables for a project. If the extendDb API is in astro:config:setup, we need to call that hook for all integrations, providing (or mocking out) the full setup API in an environment where those APIs don't really exist. This leads to an issue on both ends:

on db's end we're maintaining some faux options object in order to call the existing hook.
on integrations' end, they're tricked into thinking they can maybe do regular integration stuff (most obviously perhaps, creating a virtual module), which they can't really, because the tables need to be available in a non-Vite environment.

That said, I think ideally this PR wouldn't make the types change included here. Will pick it up in the morning.

packages/db/src/core/integration/vite-plugin-db.ts

matthewp · 2024-03-06T15:04:37Z

API overall looks good to me. Could see some adjustment in the future but not anything important enough to do now.

This reverts commit ef2156e.

delucis · 2024-03-07T15:27:15Z

!preview db-integrations-support

github-actions · 2024-03-07T15:29:13Z

Snapshots have been released for the following packages:

astro@experimental--db-integrations-support

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--db-integrations-support tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-db-integrations-support-20240307152807) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.5 is already published on npm
🦋  warn create-astro is not being published because version 4.7.3 is already published on npm
🦋  warn @astrojs/db is not being published because version 0.6.5 is already published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.0 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.9.1 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 2.1.1 is already published on npm
🦋  warn @astrojs/node is not being published because version 8.2.3 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.4 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.0.10 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.2.0 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 7.3.5 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.8 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.2.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.3 is already published on npm
🦋  info Publishing "astro" at "0.0.0-db-integrations-support-20240307152807"
🦋  success packages published successfully:
🦋  astro@0.0.0-db-integrations-support-20240307152807
🦋  Creating git tag...
🦋  New tag:  astro@0.0.0-db-integrations-support-20240307152807

Build Log


> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 27 packages
• Remote caching enabled
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs b9b2f2a6c76f5ad5
::endgroup::
::group::@astrojs/upgrade:build
cache hit, suppressing logs b1de04878f464778
::endgroup::
::group::create-astro:build
cache hit, suppressing logs 7d949ce0c94d7906
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs 8724a7242643972b
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs 3a4136a52d806948
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs dd63c2f5a3e57eb6
::endgroup::
::group::astro:build
cache miss, executing d16ef5c4a24a7a33

> astro@0.0.0-db-integrations-support-20240307152807 build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> astro@0.0.0-db-integrations-support-20240307152807 prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> astro@0.0.0-db-integrations-support-20240307152807 postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@benchmark/timer:build
cache miss, executing e2e1567b43ce9503

> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 58388cd6e4dd7779

> @astrojs/underscore-redirects@0.3.3 build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@astrojs/lit:build
cache miss, executing 25a9336d7b1bd55e

> @astrojs/lit@4.0.1 build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing 12ab431fe76c4b9f

> @astrojs/alpinejs@0.4.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 39a70b0700802fc2

> @astrojs/vercel@7.3.5 build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing de499896f49db81e

> @astrojs/solid-js@4.0.1 build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing e7e35d651e95e1c5

> @astrojs/node@8.2.3 build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing e99657f2b04cf337

> @astrojs/mdx@2.1.1 build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 153a54bf7b7d204e

> @astrojs/svelte@5.2.0 build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing 2049ca8f106b4da5

> @astrojs/vue@4.0.8 build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing a658740d0a178ea0

> @astrojs/tailwind@5.1.0 build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing e829dce4b9713c80

> @astrojs/partytown@2.0.4 build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 36ad5e5f499adb55

> @astrojs/rss@4.0.5 build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing 2dd3327ccf2b2c75

> @astrojs/react@3.0.10 build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 9bc14073a30b514a

> @astrojs/preact@3.1.1 build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing 11f567cb97986b88

> @astrojs/markdoc@0.9.1 build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 5a5bc38c2c287820

> @astrojs/sitemap@3.1.1 build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/db:build
cache miss, executing 57905efc90c7db9b

> @astrojs/db@0.6.5 build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    25 successful, 25 total
Cached:    6 cached, 25 total
  Time:    42.389s

delucis · 2024-03-07T15:48:07Z

!preview db-integrations-support

github-actions · 2024-03-07T15:50:04Z

Snapshots have been released for the following packages:

astro@experimental--db-integrations-support
@astrojs/db@experimental--db-integrations-support

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--db-integrations-support tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-db-integrations-support-20240307154857) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.0.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.5 is already published on npm
🦋  warn create-astro is not being published because version 4.7.3 is already published on npm
🦋  info @astrojs/db is being published because our local version (0.0.0-db-integrations-support-20240307154857) has not been published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.0 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.9.1 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 2.1.1 is already published on npm
🦋  warn @astrojs/node is not being published because version 8.2.3 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.0.4 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.0.10 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.1.1 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 4.0.1 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.2.0 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 7.3.5 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.0.8 is already published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.2.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 4.2.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.0.4 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.3 is already published on npm
🦋  warn @astrojs/upgrade is not being published because version 0.2.3 is already published on npm
🦋  info Publishing "astro" at "0.0.0-db-integrations-support-20240307154857"
🦋  info Publishing "@astrojs/db" at "0.0.0-db-integrations-support-20240307154857"
🦋  success packages published successfully:
🦋  astro@0.0.0-db-integrations-support-20240307154857
🦋  @astrojs/db@0.0.0-db-integrations-support-20240307154857
🦋  Creating git tags...
🦋  New tag:  astro@0.0.0-db-integrations-support-20240307154857
🦋  New tag:  @astrojs/db@0.0.0-db-integrations-support-20240307154857

Build Log


> root@0.0.0 build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro
• Running build in 27 packages
• Remote caching enabled
::group::@astrojs/internal-helpers:build
cache hit, suppressing logs b9b2f2a6c76f5ad5
::endgroup::
::group::@astrojs/prism:build
cache hit, suppressing logs 8724a7242643972b
::endgroup::
::group::@astrojs/telemetry:build
cache hit, suppressing logs 3a4136a52d806948
::endgroup::
::group::@astrojs/upgrade:build
cache hit, suppressing logs b1de04878f464778
::endgroup::
::group::create-astro:build
cache hit, suppressing logs 7d949ce0c94d7906
::endgroup::
::group::@astrojs/markdown-remark:build
cache hit, suppressing logs dd63c2f5a3e57eb6
::endgroup::
::group::astro:build
cache miss, executing d1ed52251c255653

> astro@0.0.0-db-integrations-support-20240307154857 build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> astro@0.0.0-db-integrations-support-20240307154857 prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> astro@0.0.0-db-integrations-support-20240307154857 postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing 242166dd3fbecb27

> @astrojs/underscore-redirects@0.3.3 build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json

::endgroup::
::group::@benchmark/timer:build
cache miss, executing 587d3da23c0e9c56

> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing 946665722e33fe75

> @astrojs/partytown@2.0.4 build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing 962f459ce7aa4dd9

> @astrojs/rss@4.0.5 build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing ef7153505e07fc05

> @astrojs/alpinejs@0.4.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/react:build
cache miss, executing d005cdebf879910e

> @astrojs/react@3.0.10 build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing ed2e02e9e9caa4cd

> @astrojs/preact@3.1.1 build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing fde438305aa575f4

> @astrojs/vercel@7.3.5 build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing 9595a2ad57ea3117

> @astrojs/vue@4.0.8 build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing 63f64deca9ffd488

> @astrojs/svelte@5.2.0 build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing 468a09052921f6d0

> @astrojs/lit@4.0.1 build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing 55a9edef2aa37d1b

> @astrojs/markdoc@0.9.1 build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 4960f829c47c7e2d

> @astrojs/tailwind@5.1.0 build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing c10bf2dc99e71d96

> @astrojs/node@8.2.3 build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing c6506795d3ee664f

> @astrojs/solid-js@4.0.1 build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing f05d9178d58bcf38

> @astrojs/mdx@2.1.1 build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/db:build
cache miss, executing 543b0a2901494b9f

> @astrojs/db@0.0.0-db-integrations-support-20240307154857 build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 8e9c40ddd05a01e6

> @astrojs/sitemap@3.1.1 build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    25 successful, 25 total
Cached:    6 cached, 25 total
  Time:    43.049s

natemoo-re

LGTM 🙌

.changeset/purple-poets-sin.md

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

delucis added 2 commits March 4, 2024 14:59

Add integrations API for adding db config/seed files

e10d93c

Fix seeding when user seed file is present

b80674d

github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Mar 4, 2024

delucis added 2 commits March 4, 2024 17:00

Add basic test and fixture for integrations API

3ad617a

Freeze that lockfile

54a6054

delucis added 2 commits March 4, 2024 18:23

Test to see if this is a Windows fix

2148fc9

Don’t import.meta.glob integration seed files

d2b3d89

delucis added 4 commits March 5, 2024 10:50

Make integration seed files export a default function

0ca265e

style: rejiggle

985d3a0

Fix temporary file conflicts

ef2156e

Remove changes to Astro’s core types, type utility method instead

ecd69ac

github-actions bot removed pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Mar 5, 2024

delucis force-pushed the plt-1746/db-integrations branch from b66ec9e to ecd69ac Compare March 5, 2024 20:22

Merge branch 'main' into plt-1746/db-integrations

dd3e976

matthewp reviewed Mar 5, 2024

View reviewed changes

packages/db/src/core/integration/vite-plugin-db.ts Show resolved Hide resolved

matthewp reviewed Mar 5, 2024

View reviewed changes

packages/db/src/core/integration/vite-plugin-db.ts Show resolved Hide resolved

delucis added 5 commits March 6, 2024 19:08

Merge branch 'main' into plt-1746/db-integrations

29e09e0

Use astro:db instead of @astrojs/db

76b62b1

Merge branch 'main' into plt-1746/db-integrations

b2d2522

Merge branch 'main' into plt-1746/db-integrations

76746e3

Revert unnecessarily cautious temporary path name

0d0204a

This reverts commit ef2156e.

Add changeset

59edb2d

Fix entrypoints and asDrizzleTable usage in changeset

20414ce

delucis marked this pull request as ready for review March 7, 2024 16:30

Merge branch 'main' into plt-1746/db-integrations

2d3fdba

natemoo-re approved these changes Mar 7, 2024

View reviewed changes

.changeset/purple-poets-sin.md Outdated Show resolved Hide resolved

delucis and others added 3 commits March 7, 2024 19:18

Merge branch 'main' into plt-1746/db-integrations

915123a

Getting Nate in on the co-author action

967513f

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>

Fix user seed file in integrations fixture

3ba05b6

matthewp approved these changes Mar 7, 2024

View reviewed changes

delucis added 3 commits March 7, 2024 19:56

Merge branch 'main' into plt-1746/db-integrations

2a4e7d7

Update seedLocal() after merge

1c06217

Provide empty seedFiles array in db execute

6f6593b

delucis merged commit 2e4958c into main Mar 7, 2024
13 checks passed

delucis deleted the plt-1746/db-integrations branch March 7, 2024 19:19

astrobot-houston mentioned this pull request Mar 7, 2024

[ci] release #10359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integrations API for db config/seed files #10321

Add integrations API for db config/seed files #10321

delucis commented Mar 4, 2024 •

edited

Loading

changeset-bot bot commented Mar 4, 2024 •

edited

Loading

florian-lefebvre commented Mar 4, 2024

matthewp commented Mar 4, 2024 •

edited

Loading

matthewp commented Mar 4, 2024

delucis commented Mar 4, 2024

matthewp commented Mar 6, 2024

delucis commented Mar 7, 2024

github-actions bot commented Mar 7, 2024

delucis commented Mar 7, 2024

github-actions bot commented Mar 7, 2024

natemoo-re left a comment

Add integrations API for db config/seed files #10321

Add integrations API for db config/seed files #10321

Conversation

delucis commented Mar 4, 2024 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Mar 4, 2024 • edited Loading

🦋 Changeset detected

florian-lefebvre commented Mar 4, 2024

matthewp commented Mar 4, 2024 • edited Loading

matthewp commented Mar 4, 2024

delucis commented Mar 4, 2024

matthewp commented Mar 6, 2024

delucis commented Mar 7, 2024

github-actions bot commented Mar 7, 2024

delucis commented Mar 7, 2024

github-actions bot commented Mar 7, 2024

natemoo-re left a comment

Choose a reason for hiding this comment

delucis commented Mar 4, 2024 •

edited

Loading

changeset-bot bot commented Mar 4, 2024 •

edited

Loading

matthewp commented Mar 4, 2024 •

edited

Loading