Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel speed Anaytics - new version #9590

Closed
1 task
ref-thomasledoux1 opened this issue Jan 3, 2024 · 2 comments · Fixed by #9598
Closed
1 task

Vercel speed Anaytics - new version #9590

ref-thomasledoux1 opened this issue Jan 3, 2024 · 2 comments · Fixed by #9598
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: vercel Related to Vercel adapter (scope)

Comments

@ref-thomasledoux1
Copy link

Astro Info

Not relevant

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

At the moment in the docs it's recommended to use speedInsights through the vercel adapter to enable Speed Analytics on Vercel.
But in the newest version of the Speed Analytics, it's recommended by Vercel to use their package to do tracking of speed analytics, not longer matching the current approach which the adapter option provides.
The migration docs can be found here: https://vercel.com/docs/speed-insights/migrating-from-legacy

Now the question is: can the adapter be changed to support the new way of working for Speed Analytics measurement, or should the option be deleted from the adapter, and should the docs point to the Vercel + Astro Speed analytics example here: https://github.com/vercel/speed-insights/blob/main/apps/astro ?

What's the expected result?

Answer to above :-)

Link to Minimal Reproducible Example

Not possible

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 3, 2024
@lilnasy
Copy link
Contributor

lilnasy commented Jan 3, 2024

Hi, thanks for bringing this up. The vercel adapter does not prevent you from using the new API. In fact, users in this thread have already been using it.

The update in the adapter will only deprecate the old system that requires adapter involvement.

@lilnasy lilnasy added - P2: nice to have Not breaking anything but nice to have (priority) pkg: vercel Related to Vercel adapter (scope) and removed needs triage Issue needs to be triaged labels Jan 3, 2024
@thomasledoux1
Copy link

Hi, thanks for bringing this up. The vercel adapter does not prevent you from using the new API. In fact, users in this thread have already been using it.

The update in the adapter will only deprecate the old system that requires adapter involvement.

Alright, I thought so. Thanks for the reply. I indeed found the thread you mentioned already and implemented it as per the example, works perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority) pkg: vercel Related to Vercel adapter (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants