Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slot name is being rendered as an attribute on Vue component #8921

Closed
1 task
spacedawwwg opened this issue Oct 25, 2023 · 1 comment · Fixed by #8930
Closed
1 task

Slot name is being rendered as an attribute on Vue component #8921

spacedawwwg opened this issue Oct 25, 2023 · 1 comment · Fixed by #8930
Assignees
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@spacedawwwg
Copy link

spacedawwwg commented Oct 25, 2023

Astro Info

Astro                    v3.3.4
Node                     v18.17.1
System                   macOS (arm64)
Package Manager          yarn
Output                   server
Adapter                  none
Integrations             @astrojs/vue
                         astro-purgecss
                         astro-compress

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When using a slot name on a Vue component, the slot name is being rendered as an attribute

something like:

<Parent>
  <Child slot="footer" />
</Parent>

renders like:

<div class="parent"> 
  <div class="parent-footer">
    <div class="child" slot="footer">I am the child</div>
  </div>
</div>
image

What's the expected result?

No slot attribute rendered on component

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-1jemj8

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Oct 25, 2023
@matthewp
Copy link
Contributor

Ah, good catch, probably a quick fix, let me take a look.

@matthewp matthewp added - P3: minor bug An edge case that only affects very specific usage (priority) and removed needs triage Issue needs to be triaged labels Oct 26, 2023
@matthewp matthewp self-assigned this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants