node ssr dont showing 404 page

[polioan]

What version of astro are you using?

1.6.12

Are you using an SSR adapter? If so, which one?

node

What package manager are you using?

npm

What operating system are you using?

Windows (but linux have same behavior)

Describe the Bug

This behavior is similar on standalone and middleware mode. When using vite dev server - all ok, default or custom 404 page are showing. But when using build Instead of 404 page - plain text are showing.

run "npm run serve" for starting server in production (build) mode

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-cddzmd

Participation

• I am willing to submit a pull request for this issue.

[JerryWu1234]

mark

[JerryWu1234]

I know why can't appears 404 page that the user created. but I have a question about the default 404 page.

This page only appears in the dev.

Are you intentional?

[bluwy]

@wulinsheng123 Yes I think that's intentional for dev only if the user doesn't provide a custom 404 page. For production, it should default to what the server would respond for 404.

Looking into the issue, looks like this is because we don't pass { matchNotFound: true } here. But we can't pass it because it might be a middleware, other middlewares might want to handle the request for something else instead of 404.

I think the fix here is that, if we're building for standalone mode, we set { matchNotFound: true }. For middleware mode, we can leave it as is, but a nice bonus feature is if the server build output export a second middleware that handles 404.html serving only.

[JerryWu1234]

Thanks for your tips.
I will fix it hard this week。

[bluwy]

Fixed in #5701

[schroedan]

@bluwy Well, the problem was only half fixed. The 404 handler is missing in the middleware module exports. We can work around this in our case by building for standalone mode, setting ASTRO_NODE_AUTOSTART env to disabled and using the handler from the standalone module. But this is not a very clean way in my opinion.

[JerryWu1234]

@bluwy Well, the problem was only half fixed. The 404 handler is missing in the middleware module exports. We can work around this in our case by building for standalone mode, setting ASTRO_NODE_AUTOSTART env to disabled and using the handler from the standalone module. But this is not a very clean way in my opinion.

could you give a minimal duplicated rep ?

[romannurik]

It's possible 298dbb8 may have broken this again? (or that commit fixes this in a future Astro version?)

[lilnasy]

@romannurik Some of the issues introduced by #7754 (released in astro v2.9.7) were fixed recently.

Please check with the latest version and if it's still there check the feat: 404 label to see if an issue for the bug is already open.

[romannurik]

@romannurik Some of the issues introduced by #7754 (released in astro v2.9.7) were fixed recently.

Please check with the latest version and if it's still there check the feat: 404 label to see if an issue for the bug is already open.

Thanks! Looks like I'm hitting this already reported issue, so I'll subscribe to updates there: #7881

EDIT: I actually think I'm hitting this one? Essentially my 404.astro, with prerender = false (in output=hybrid), using the node integration in middleware mode, renders the 404 in dev but not in prod

[romannurik]

FWIW, this horrid hack DOES work for me:

app.use(astroSsrHandler);
app.use((req, res, next) => {
  // only called if astroSsrHandler didn't handle this request originally
  req.url = '/404';
  astroSsrHandler(req, res, next);
});

So in my situation (see comment above), before this hack, visiting /404, or a page that returned new Response(null, { status: 404 }) correctly rendered the 404, but visiting some random non-existent URL seemed to be skipped over by the middleware