🐛 BUG: Sending binary body is broken with node adapter SSR

[tkamenoko]

What version of astro are you using?

0.0.0-rc-20220726043527

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the Bug

Sending a binary content is broken on api route.

Example request:

const requestBody = Uint8Array.from([0,1,33,233])

const response = await fetch("/api/echo", {
  method: "post",
  body: requestBody,
  headers: { "Content-Type": "application/octet-stream" }
});

const responseBody = new Uint8Array(await response.arrayBuffer())
console.log(requestBody)
console.log(responseBody)

Stdout:

Uint8Array(4) [ 0, 1, 33, 233 ]
Uint8Array(6) [ 0, 1, 33, 239, 191, 189 ]

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-xdurhs-q4pmtc

Participation

• I am willing to submit a pull request for this issue.

[tkamenoko]

I found PR #4023 that fixes empty body bug, but it seems to allow only UTF-8 contents.

astro/packages/astro/src/core/app/node.ts

Lines 25 to 57 in adf8cde

	export class NodeApp extends App {
	match(req: IncomingMessage | Request) {
	return super.match(req instanceof Request ? req : createRequestFromNodeRequest(req));
	}
	render(req: IncomingMessage | Request) {
	if ('on' in req) {
	let body: string | undefined = undefined;
	let reqBodyComplete = new Promise((resolve, reject) => {
	req.on('data', (d) => {
	if (body === undefined) {
	body = '';
	}
	if (d instanceof Buffer) {
	body += d.toString('utf-8');
	} else if (typeof d === 'string') {
	body += d;
	}
	});
	req.on('end', () => {
	resolve(body);
	});
	req.on('error', (err) => {
	reject(err);
	});
	});
	return reqBodyComplete.then(() => {
	return super.render(req instanceof Request ? req : createRequestFromNodeRequest(req, body));
	});
	}
	return super.render(req instanceof Request ? req : createRequestFromNodeRequest(req));
	}
	}

It always decodes a request body as UTF-8 string.

[matthewp]

Ah yeah, it should be building up a Buffer I guess.