Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix edge-case in _routes.json generation #64

Closed
alexanderniebuhr opened this issue Nov 14, 2023 · 2 comments · Fixed by #69
Closed

fix edge-case in _routes.json generation #64

alexanderniebuhr opened this issue Nov 14, 2023 · 2 comments · Fixed by #69
Labels
- P2: has workaround Bug, but has workaround (priority) pkg: cloudflare

Comments

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 14, 2023 •
edited
Loading

@alexanderniebuhr alexanderniebuhr added - P3: minor bug An edge case that only affects very specific usage (priority) - P2: has workaround Bug, but has workaround (priority) pkg: cloudflare and removed - P3: minor bug An edge case that only affects very specific usage (priority) labels Nov 14, 2023
@alexanderniebuhr
Copy link
Member Author

https://discord.com/channels/595317990191398933/1174021841023664288

This was referenced Nov 15, 2023
Closed
Merged
@lilnasy
Copy link
Contributor

lilnasy commented Nov 16, 2023

Ran some previews to single out the configurations/defaults that make index.astro render for unrouted paths.

Shared in a PR comment here: #66 (comment)

@alexanderniebuhr alexanderniebuhr mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P2: has workaround Bug, but has workaround (priority) pkg: cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloudflare): routing strategy doesn't support on-demand 404 withastro/adapters
2 participants
@alexanderniebuhr @lilnasy