Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_globs has an unnecessary "*" at the front of each pattern #20

Open
Rob--W opened this issue Aug 24, 2021 · 0 comments
Open

include_globs has an unnecessary "*" at the front of each pattern #20

Rob--W opened this issue Aug 24, 2021 · 0 comments

Comments

@Rob--W
Copy link
Collaborator

Rob--W commented Aug 24, 2021

"*http should be replaced with "http at

"*https://www.google.*",
"*https://maps.google.*",
"*http://www.google.*",
"*http://maps.google.*"

Because include_globs is evaluated after the specific patterns in matches is applied, this doesn't inadvertently result in incorrect matches, but still it would be nice to omit the unnecessary * prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant