Skip to content

@EnableWireMock should be @Inherited #83

Closed
@GokcenTim

Description

@GokcenTim

Proposal

The annotation @EnableWireMock should itself be annotated with @Inherited so that it is obvious it can be applied to classes that will be inherited by actual tests.

The WireMockContextCustomizerFactory does actually recursively search a class' superclasses for @EnableWireMock annotations, but this is not obvious from the documentation (neither README.md nor the Javadocs on @EnableWireMock mention it). Instead of performing the recursive search, annotating with @Inherited would make it obvious to users that the annotation can be used on super classes, as well as remove the need to recursively search the ancestors of the current class to find the annotation.

Alternatively, the documentation should be updated to indicate that superclasses will be searched.

References

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions