WPB-4559 user receives 2 k federation connection removed on anta #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
fisx
reviewed
Sep 14, 2023
There was a problem hiding this comment.
This looks very reasonable, unfortunately it is about to be deprecated by the more robust #3582.
This PR is probably good for code mining when we have a new architecture and implement this again, Galley.API.BackgroundProcesses in particular looks useful.
| -- You should have received a copy of the GNU Affero General Public License along | ||
| -- with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| module Galley.API.BackgroundProcesses where |
There was a problem hiding this comment.
Suggested change
| module Galley.API.BackgroundProcesses where | |
| module Galley.BackgroundProcesses where |
not part of the rest api, right?
Comment on lines
+46
to
+47
| -- | Remove all conversations and members from the local domain. This must only be run in a background process | ||
| unsafeRemoveRemoteMembersFromLocalConversation :: |
There was a problem hiding this comment.
why is it unsafe? because it's not fit for HTTP? then i'd call it bg instead.
|
obsolote because of #3582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-4559
Checklist
changelog.d