[chore] apply Akshay's suggestions

Author: MangoIV

hack/bin/bombon.hs

@@ -7,36 +7,11 @@ import Data.Text qualified as T
 import Turtle
 
 main = do
-  release <- options "Upload boms" do
-    optText "release" 't' "Which release tag to upload the artifacts to"
-
-  with (mktempdir "." "tmp") \tmpDir -> do
-    cd tmpDir
-    let git l = proc "git" l mempty
-    git ["clone", "https://github.com/mangoiv/wire-server", "."]
-    git ["checkout", release]
-    git ["submodule", "update", "--init", "--recursive"]
-    let bomName = "wire-server-bom-" <> release <> ".json"
-    ExitSuccess <-
-      proc
-        "nix"
-        [ "build",
-          "-f",
-          "nix",
-          "wireServer.allLocalPackagesBom",
-          "-o",
-          bomName
-        ]
-        mempty
-    printf ("uploading " % s % " to release " % s % "\n") bomName ("chart/" <> release)
-    proc
-      "gh"
-      [ "-R",
-        "mangoiv/wire-server",
-        "release",
-        "upload",
-        "chart/" <> release,
-        bomName
-      ]
-      mempty
-  pure ()
+  (release, repo) <- options "Upload boms" do
+    (,)
+      <$> optText "release" 't' "Which release tag to upload the artifacts to"
+      <*> optText "repo" 'r' "Which repository to upload the artifacts to"
+  let bomName = "wire-server-bom-" <> release <> ".json"
+  ExitSuccess <- proc "nix" ["build", "-f", "nix", "wireServer.allLocalPackagesBom", "-o", bomName] mempty
+  printf ("uploading " % s % " to release " % s % "\n") bomName ("chart/" <> release)
+  proc "gh" ["-R", repo, "release", "upload", "chart/" <> release, bomName] mempty

nix/wire-server.nix

@@ -464,18 +464,15 @@ let
     paths = map (e: (hPkgs localModsEnableAll).${e}) wireServerPackages;
   };
 
-  allImages = pkgs.linkFarm "all-images" (images localModsEnableAll) ;
+  allImages = pkgs.linkFarm "all-images" (images localModsEnableAll);
 
   # BOM is an acronym for bill of materials
   allLocalPackagesBom = lib.buildBom allLocalPackages {
     includeBuildtimeDependencies = true;
   };
-  allImagesBom = lib.buildBom allImages {
-    includeBuildtimeDependencies = true;
-  };
 in
 {
-  inherit ciImage hoogleImage allImages allImagesBom allLocalPackages allLocalPackagesBom;
+  inherit ciImage hoogleImage allImages allLocalPackages allLocalPackagesBom;
 
   images = images localModsEnableAll;
   imagesUnoptimizedNoDocs = images localModsOnlyTests;