Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable countly performance metrics (WPB-8842) #3481

Merged
merged 11 commits into from
Oct 2, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 1, 2024

TaskWPB-8842 [Android] Implement Performance metrics provided by countly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Enable performance analytics for the application

Causes (Optional)

If the user has analytics enabled, the SDK will track some performance metrics.

Solutions

What's tracked ?

  • App startup, time in foreground, time on foreground
  • Views names and general info about it (Not performance)

What's NOT tracked ?

  • Networking, for now, due to layer not available for Countly
  • Views, the SDK supports only the old Android View system, not compose.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open, the app and play with the views and, you should see on countly tracking of views, and perf metrics for app startup foreground time, and background time,


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.


Countly.sharedInstance().init(countlyConfig)
Countly.sharedInstance().consent().giveConsent(arrayOf("apm"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime consent given to the SDK for performance metrics, only enabled if analytics enabled.

@yamilmedina yamilmedina requested review from alexandreferris, saleniuk, MohamadJaara, a team, borichellow and damian-kaczmarek and removed request for a team October 1, 2024 18:43
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 1, 2024
@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 2, 2024
Copy link

sonarcloud bot commented Oct 2, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.43%. Comparing base (da7c22a) to head (3fb83aa).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...tlin/com/wire/android/util/CurrentScreenManager.kt 33.33% 12 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
...otlin/com/wire/android/ui/WireActivityViewModel.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3481      +/-   ##
===========================================
- Coverage    44.60%   44.43%   -0.17%     
===========================================
  Files          467      466       -1     
  Lines        15783    15744      -39     
  Branches      2655     2653       -2     
===========================================
- Hits          7040     6996      -44     
- Misses        7986     7991       +5     
  Partials       757      757              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 69.89% <83.33%> (ø)
...tlin/com/wire/android/util/CurrentScreenManager.kt 36.23% <33.33%> (-6.63%) ⬇️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7c22a...3fb83aa. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Built wire-android-staging-compat-pr-3481.apk is available for download

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Built wire-android-dev-debug-pr-3481.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit 59f9c3d Oct 2, 2024
12 checks passed
@yamilmedina yamilmedina deleted the feat/countly-performance-metrics branch October 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants