Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra info for users without avatars in missing places (WPB-1750) #3403

Merged
merged 30 commits into from
Aug 30, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 28, 2024

StoryWPB-1750 [User avatar] Handle user avatars for users without user image


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to show. For users without avatars (they never got, defined one) to use the initials of their name and the accentColor they have.

Causes (Optional)

Paying an UX debt.

Solutions

Add the missing info to the places we need, mainly accent color.
An upcoming PR will follow in AR.

Depends on

Attachments

Screen.Recording.2024-08-29.at.16.05.12.mov
Screen.Recording.2024-08-29.at.16.14.15.mov
Screen.Recording.2024-08-29.at.21.04.20.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 28, 2024
@yamilmedina yamilmedina changed the title Feat/users without avatars feat: add extra info for users without avatars in missing places (WPB-1750) Aug 28, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 29, 2024
@yamilmedina yamilmedina marked this pull request as ready for review August 30, 2024 07:56
@yamilmedina yamilmedina requested review from borichellow and removed request for typfel August 30, 2024 07:56
@yamilmedina yamilmedina added this pull request to the merge queue Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.

Project coverage is 44.51%. Comparing base (a279811) to head (3c5735b).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...in/kotlin/com/wire/android/model/UserAvatarData.kt 25.00% 9 Missing ⚠️
...in/kotlin/com/wire/android/mapper/ContactMapper.kt 0.00% 6 Missing ⚠️
...ome/conversationslist/ConversationListViewModel.kt 42.85% 0 Missing and 4 partials ⚠️
.../main/kotlin/com/wire/android/ui/home/HomeState.kt 25.00% 3 Missing ⚠️
.../wire/android/ui/calling/SharedCallingViewModel.kt 0.00% 2 Missing ⚠️
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 66.66% 0 Missing and 1 partial ⚠️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt 85.71% 0 Missing and 1 partial ⚠️
...oid/ui/home/conversations/ConversationMemberExt.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3403      +/-   ##
===========================================
+ Coverage    44.48%   44.51%   +0.02%     
===========================================
  Files          464      464              
  Lines        15507    15542      +35     
  Branches      2593     2602       +9     
===========================================
+ Hits          6899     6918      +19     
- Misses        7875     7888      +13     
- Partials       733      736       +3     
Files with missing lines Coverage Δ
...com/wire/android/mapper/UICallParticipantMapper.kt 93.33% <100.00%> (+0.47%) ⬆️
...in/kotlin/com/wire/android/ui/calling/CallState.kt 100.00% <100.00%> (ø)
...wire/android/ui/calling/model/UICallParticipant.kt 100.00% <100.00%> (ø)
...alling/ongoing/participantsview/ParticipantTile.kt 0.00% <ø> (ø)
...me/conversations/info/ConversationInfoViewModel.kt 82.89% <100.00%> (+0.95%) ⬆️
...me/conversations/info/ConversationInfoViewState.kt 100.00% <100.00%> (ø)
...erprofile/other/OtherUserProfileScreenViewModel.kt 59.79% <100.00%> (+0.20%) ⬆️
...roid/ui/userprofile/other/OtherUserProfileState.kt 76.59% <100.00%> (+0.50%) ⬆️
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 52.51% <100.00%> (+0.34%) ⬆️
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a279811...3c5735b. Read the comment docs.

@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Aug 30, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3403.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3403.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3403.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3403.apk is available for download

Copy link

sonarcloud bot commented Aug 30, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit 1e6d17c Aug 30, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/users-without-avatars branch August 30, 2024 12:44
Copy link
Contributor

Built wire-android-staging-compat-pr-3403.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3403.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants