Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flickering call other participants video (WPB-9617) #3188

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 17, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

TL;DR; This PR #3034 upgraded the compose libraries to beta01. That had an unintended side effect with AndroidView component that we use for rendering other participants video streams.

A long story of debugging and side effects.

After checking recompositions and validating that these were skipped, as well, validating the code visually. I checked for the latest working version, this being initially (4.6.4) previous prod.

The candidates that could have introduced the bug were:

And no clue after those were ok, so checking with @ohassine the idea came to validate for dependencies changes. We stumbled upon the PR with the regression, this by validating installing and updating old Apks.

The issue was no present in 1.7.0-alpha05 but it is from 1.7.0-beta01 to 1.7.0-beta04.
The fix is present in the latest version 1.7.0-beta05 https://developer.android.com/jetpack/androidx/releases/compose-ui#1.7.0-beta05

Causes (Optional)

Regression in the compose dependency.

Solutions

Bump to the newest version, and also avoid unnecessary collection of the flow emissions for call state (not related, but efficient improvement)

Testing

Tested manually after version bump.

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 17, 2024
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Jul 17, 2024
Copy link

sonarcloud bot commented Jul 17, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3188.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3188.apk is available for download

@ohassine ohassine added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit 129fb9a Jul 18, 2024
16 of 21 checks passed
@ohassine ohassine deleted the fix/flickering-callvideo branch July 18, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants