Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avs and cc versions in new section about this app (WPB-5935) #3181

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 15, 2024

TaskWPB-5935 [Android] AVS version should be shown in the UI for better transparency


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to provide versions of AVS and CC in the app.

Causes (Optional)

New design specs

Solutions

  • Implement accordingly to new specs from Figma
  • Add new section "wire website"

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 15, 2024
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and vitorhugods and removed request for a team July 15, 2024 12:46
Copy link

sonarcloud bot commented Jul 15, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3181.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3181.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Jul 15, 2024
Merged via the queue into develop with commit 68d134b Jul 15, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/avs-cc-versions branch July 15, 2024 15:02
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants