Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies before code freeze #2934

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 24, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Updating libraries versions, taken from dependabot log, before code freeze.
Also removes spotless, since was never used.

Needs release with


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team April 24, 2024 09:18
@yamilmedina yamilmedina self-assigned this Apr 24, 2024
@yamilmedina yamilmedina requested review from typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team April 24, 2024 09:18
Copy link
Contributor

github-actions bot commented Apr 24, 2024

Test Results

22 tests   - 881   22 ✅  - 881   0s ⏱️ - 13m 3s
 5 suites  - 118    0 💤 ±  0 
 5 files    - 118    0 ❌ ±  0 

Results for commit 474cf3e. ± Comparison against base commit 7b3b0ac.

This pull request removes 881 tests.
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given few valid accounts, when starting observing accounts, then create user-specific notification channels()
com.wire.android.GlobalObserversManagerTest ‑ given valid accounts, at least one with persistent socket enabled, and socket service running, then do not start service again()
com.wire.android.GlobalObserversManagerTest ‑ given validAccounts and persistentStatuses are out of sync, when setting up notifications, then ignore invalid users()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1DayAnd12Hours_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
com.wire.android.SelfDeletionTimerTest ‑ givenTimeLeftIs1HourAnd12Minutes_whenRecalculatingTimeAfterIntervals_thenTimeLeftIsEqualToExpected()
…

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4412 failed.

@AndroidBob
Copy link
Collaborator

Build 4413 failed.

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
edfe85e725d316f115c81c125e22a749c5f9640e dc7f4e7566cca42d5e598fbfb7057cee76d1af83

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 4420 failed.

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
edfe85e725d316f115c81c125e22a749c5f9640e dc7f4e7566cca42d5e598fbfb7057cee76d1af83

Is this intentional?

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
edfe85e725d316f115c81c125e22a749c5f9640e dc7f4e7566cca42d5e598fbfb7057cee76d1af83

Is this intentional?

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.98%. Comparing base (6bf7e6d) to head (b8d4a1f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2934      +/-   ##
===========================================
- Coverage    44.09%   43.98%   -0.11%     
===========================================
  Files          442      442              
  Lines        14302    14301       -1     
  Branches      2458     2457       -1     
===========================================
- Hits          6306     6290      -16     
- Misses        7305     7327      +22     
+ Partials       691      684       -7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf7e6d...b8d4a1f. Read the comment docs.

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
edfe85e725d316f115c81c125e22a749c5f9640e f6fa50486331f535ccddf5590d6bdf148d434c07

Is this intentional?

Copy link
Contributor

@yamilmedina looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
edfe85e725d316f115c81c125e22a749c5f9640e f6fa50486331f535ccddf5590d6bdf148d434c07

Is this intentional?

@yamilmedina yamilmedina added this pull request to the merge queue Apr 24, 2024
@AndroidBob
Copy link
Collaborator

Build 4428 succeeded.

The build produced the following APK's:

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 24, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Apr 24, 2024
Merged via the queue into develop with commit 17ab3ae Apr 24, 2024
12 checks passed
@yamilmedina yamilmedina deleted the chore/update-deps-brefore-freeze branch April 24, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants