Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sketch): draw and send sketchs messages #2905

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Apr 17, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Drawing sketches designs applied to poc and main actions, undo, send, color picker.

Solutions

This is a compilation of small PRs

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Screen.Recording.2024-04-17.at.10.23.37.mp4
Screen_Recording_20240415_182208_Wire.Dev.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@yamilmedina yamilmedina requested review from Garzas, alexandreferris, MohamadJaara, a team, vitorhugods, mchenani and saleniuk and removed request for a team April 17, 2024 10:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 24.41860% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 43.82%. Comparing base (25ec09e) to head (eb23e62).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2905      +/-   ##
===========================================
+ Coverage    43.77%   43.82%   +0.05%     
===========================================
  Files          435      438       +3     
  Lines        14258    14334      +76     
  Branches      2476     2483       +7     
===========================================
+ Hits          6241     6282      +41     
- Misses        7323     7359      +36     
+ Partials       694      693       -1     
Files Coverage Δ
...me/conversations/info/ConversationInfoViewState.kt 100.00% <100.00%> (ø)
...re/android/util/CurrentConversationDetailsCache.kt 100.00% <100.00%> (ø)
.../wire/android/util/debug/FeatureVisibilityFlags.kt 0.00% <ø> (ø)
.../wire/android/feature/sketch/model/DrawingState.kt 100.00% <100.00%> (+100.00%) ⬆️
...m/wire/android/feature/sketch/DrawingToolPicker.kt 0.00% <0.00%> (ø)
...android/feature/sketch/tools/DrawingToolsConfig.kt 0.00% <0.00%> (ø)
...e/android/feature/sketch/DrawingCanvasComponent.kt 0.00% <0.00%> (ø)
...roid/feature/sketch/model/DrawingPathProperties.kt 9.09% <4.16%> (+9.09%) ⬆️
...e/android/feature/sketch/DrawingCanvasViewModel.kt 49.12% <30.95%> (+49.12%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ec09e...eb23e62. Read the comment docs.

Copy link
Contributor

Test Results

898 tests  +8   898 ✅ +8   8m 40s ⏱️ - 9m 11s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit eb23e62. ± Comparison against base commit 25ec09e.

This pull request removes 1 and adds 9 tests. Note that renamed tests count towards both.
com.wire.android.feature.sketch.ExampleUnitTest ‑ addition_isCorrect
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenDrawingEvent_WhenCallingTheAction_ThenUpdateTheStateWithTheCurrentMovingPathPosition
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenOnColorChanged_WhenCallingTheAction_ThenUpdateCurrentPathWithTheSelectedColor
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenOnDrawIsCalled_WhenCallingTheAction_ThenUpdateStateWithEventMove
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenOnStartDrawingIsCalled_WhenCallingTheAction_ThenUpdateStateWithEventDown
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenOnStopDrawingIsCalled_WhenCallingTheAction_ThenUpdateStateWithEventUp
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenStartDrawingEvent_WhenCallingTheAction_ThenUpdateTheStateWithTheInitialPathPosition
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenStopDrawingEvent_WhenCallingTheAction_ThenUpdateTheStateWithTheFinalPathPosition
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenWeCancelToDiscard_WhenCallingTheAction_ThenUpdateStateToHideConfirmation
com.wire.android.feature.sketch.DrawingCanvasViewModelTest ‑ givenWeWantToDiscard_WhenCallingTheAction_ThenUpdateStateToShowConfirmation

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@AndroidBob
Copy link
Collaborator

Build 4267 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Apr 17, 2024
@vitorhugods vitorhugods changed the title feat(sketch): draw sketchs epic feat(sketch): draw and send sketchs messages Apr 17, 2024
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious 🧑‍🍳🤌🏻

Merged via the queue into develop with commit 41f33b7 Apr 17, 2024
17 checks passed
@yamilmedina yamilmedina deleted the epic/draw-sketchs branch April 17, 2024 13:11
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants