feat(mls): reevaluate protocol on demand [WPB-5049] #2502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As seen on:
Solutions
Kalium now exposes a
NotifyConversationIsOpenUseCase
. This way it can perform sanity checks when it knows that the conversation is visible to the user.This PR adds a call to the new use case within
ConversationBannerViewModel
. Ensuring that every time a conversation is opened, Kalium will figure out its magic. Corresponding tests have also been added to validate this functionality.Dependencies
Needs releases with:
Testing
Test Coverage
How to Test
Navigate to any conversation. The UseCase should be called. Kalium will decide whether or not to upgrade protocol.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.