-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control questionPic size #68
Comments
Referring to the questionPic prop. I am new to this, but i didn't see ti anywhere to set width or height? |
Hi @wingkwong, I wanted to check if this enhancement is still required. If so, I'd be happy to work on it. Please feel free to assign the issue to me. |
@marceloams yes. go ahead. thanks. |
Hey @wingkwong, I've implemented the changes and added two new props: questionPicHeight and questionPicWidth. However, I have a question regarding the image size behavior. Should the image be constrained to fit within the maximum width of the container, or is it acceptable for the image to overflow beyond the container if its dimensions exceed the container's limits? Here are two examples demonstrating the different behaviors: Image constrained within the container (wrapped to the max width): Image overflowing beyond the container (allowing it to exceed the width): |
prefer the first one |
- The image size can now be customized or dynamically adjusted as per requirements. - Introduced and props to allow manual size control.
- The image size can now be customized or dynamically adjusted as per requirements. - Introduced and props to allow manual size control.
Can the size of the "quesitonPic" image be set?
The text was updated successfully, but these errors were encountered: