Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control questionPic size #68

Open
lacheporter-zz opened this issue Aug 9, 2021 · 5 comments · May be fixed by #345
Open

Control questionPic size #68

lacheporter-zz opened this issue Aug 9, 2021 · 5 comments · May be fixed by #345
Assignees
Labels
enhancement New feature or request

Comments

@lacheporter-zz
Copy link

Can the size of the "quesitonPic" image be set?

@lacheporter-zz
Copy link
Author

Referring to the questionPic prop. I am new to this, but i didn't see ti anywhere to set width or height?

@wingkwong wingkwong added the enhancement New feature or request label Aug 11, 2021
@marceloams
Copy link

Hi @wingkwong,

I wanted to check if this enhancement is still required. If so, I'd be happy to work on it. Please feel free to assign the issue to me.

@wingkwong
Copy link
Owner

@marceloams yes. go ahead. thanks.

@marceloams
Copy link

Hey @wingkwong,

I've implemented the changes and added two new props: questionPicHeight and questionPicWidth. However, I have a question regarding the image size behavior. Should the image be constrained to fit within the maximum width of the container, or is it acceptable for the image to overflow beyond the container if its dimensions exceed the container's limits?

Here are two examples demonstrating the different behaviors:

Image constrained within the container (wrapped to the max width):
Captura de tela de 2024-10-11 21-56-39

Image overflowing beyond the container (allowing it to exceed the width):
Captura de tela de 2024-10-11 21-56-11

@wingkwong
Copy link
Owner

prefer the first one

marceloams added a commit to marceloams/react-quiz-component that referenced this issue Oct 12, 2024
- The image size can now be customized or dynamically adjusted as per requirements.
- Introduced  and  props to allow manual size control.
marceloams added a commit to marceloams/react-quiz-component that referenced this issue Oct 12, 2024
- The image size can now be customized or dynamically adjusted as per requirements.
- Introduced  and  props to allow manual size control.
@marceloams marceloams linked a pull request Oct 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants