Skip to content

Commit 1b9c154

Browse files
authored
Merge pull request #101 from windingtree/feat/open_close_db
Feat/open close db
2 parents d124cef + 118765c commit 1b9c154

File tree

4 files changed

+23
-1
lines changed

4 files changed

+23
-1
lines changed

packages/storage/src/abstract.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ export abstract class Storage {
1313
abstract entries<CustomValueType = unknown>():
1414
| IterableIterator<[string, CustomValueType]>
1515
| Promise<[string, CustomValueType][]>;
16+
abstract open(): Promise<void>;
17+
abstract close(): Promise<void>;
1618
}
1719

1820
export interface GenericStorageOptions {

packages/storage/src/level.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,14 @@ export class LevelDBStorage extends Storage {
264264
*
265265
* @memberof LevelDBStorage
266266
*/
267-
async open() {
267+
async open(): Promise<void> {
268268
await this.db.open();
269269
}
270270

271+
async close(): Promise<void> {
272+
await this.db.close();
273+
}
274+
271275
/**
272276
* Returns the LevelDB instance
273277
*

packages/storage/src/local.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,14 @@ export class LocalStorage extends Storage {
258258

259259
return entriesIterator();
260260
}
261+
262+
close(): Promise<void> {
263+
return Promise.resolve(undefined);
264+
}
265+
266+
open(): Promise<void> {
267+
return Promise.resolve(undefined);
268+
}
261269
}
262270

263271
/**

packages/storage/src/memory.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,14 @@ export class MemoryStorage extends Storage {
223223
? entriesIterator()
224224
: (this.db.entries() as IterableIterator<[string, ValueType]>);
225225
}
226+
227+
close(): Promise<void> {
228+
return Promise.resolve(undefined);
229+
}
230+
231+
open(): Promise<void> {
232+
return Promise.resolve(undefined);
233+
}
226234
}
227235

228236
// Storage configuration

0 commit comments

Comments
 (0)