-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripgrep 13 search stuck when using options in neovim #82
Comments
Thanks for the report @augur97.
Thanks for the report. I think the issue is that it isn't smart enough to distinguish options which take arguments from options which don't. So, when it sees:
It sees So basically, we need to make the hack quite a bit smarter, so that it knows that
|
Hello
Maybe we could add this quirk to the documentation? |
We could, but I'd rather just fix it... because if you can remember to do |
I have a possible fix up on the |
Hello
Thanks for the awesome plugin
I have encountered a bug like #78 when using ripgrep 13 and the nightly version
of neovim (v0.7.0-dev+969-gb2f77c354)
When I search with :Ack, and pass options to rg (for example --type to search
for an specific file type) the command hangs
To reproduce:
The command executed is
/usr/bin/rg --vimgrep --no-heading --no-config --max-columns 4096 TODO --type go
This can be avoided by appending a '.' to the command like so
:Ack TODO --type go .
If I do a search without options the command is
/usr/bin/rg --vimgrep --no-heading --no-config --max-columns 4096 TODO .
Also when I try to search again it fails with error that it cannot cancel job.
So I think that the problem is that the fix introduced to fix #78 does not
consider additional options to the rg command
The minimal reproduction config is (run :PackerSync to install plugins)
Kind regards
The text was updated successfully, but these errors were encountered: