Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermium version number mismatch. #810

Closed
mina354 opened this issue Aug 21, 2024 · 8 comments
Closed

Supermium version number mismatch. #810

mina354 opened this issue Aug 21, 2024 · 8 comments
Labels
Minor bug A bug that does not break the browser

Comments

@mina354
Copy link

mina354 commented Aug 21, 2024

Describe the bug
Supermium version displayed in the About page is different than the one displayed in Programs and Features.

To Reproduce
Steps to reproduce the behavior:

  1. Open Supermium.
  2. Click on the hamburger menu, then click About Supermium.
  3. Open Control Panel, then go to Programs and Features
  4. Compare the version displayed in About Supermium window, and the version displayed in Programs and Features. There's a mismatch.

Expected behavior
Both versions become the same.

Screenshots
image
image

Desktop (please complete the following information):
OS: Windows 7 SP1 x64 (but it happens under any supported OS)

@mina354 mina354 added the Minor bug A bug that does not break the browser label Aug 21, 2024
@Vangelis66

This comment was marked as off-topic.

@mina354
Copy link
Author

mina354 commented Aug 22, 2024

do the new installers exhibit the same bug?

Yes, they do.

@Vangelis66
Copy link

Yes, they do

Thanks for the report 👍 ; it was much later I discovered the Supermium-124-r2 installers were, in fact, updated to incorporate a fixed fonts file, as per this 😉 ; sorry for the trouble caused 😄 ...

@mina354
Copy link
Author

mina354 commented Aug 26, 2024

sorry for the trouble caused 😄 ...

Well, no worries, my bug report is about something minor, but it would be great if @win32ss fixes it anyway.

@kda2495
Copy link

kda2495 commented Sep 5, 2024

Doesn't fixed in latest 126 release.

@mina354
Copy link
Author

mina354 commented Sep 7, 2024

Doesn't fixed in latest 126 release.

Yeah, I realize that too.

@Vangelis66
Copy link

Vangelis66 commented Sep 9, 2024

(Isn't) fixed in latest 126 release.

... I believe the root cause of this bug is the code below:

https://github.com/win32ss/supermium-installer/blob/987167d54c83d8dc2986ae4fd69f1ff73835e48d/supermium_installer_v3/supermium_installer_v3/supermium_installer_v3.cpp#L269

It still references 122.0.6261.152, while this value should be updated before compilation with whatever Supermium version (126.0.6478.249 being the current) the installer is about to bundle 😉 ...

@Vangelis66
Copy link

... If this bug has been fixed for the OP 😉 with latest Sm-126-r3 release, then this issue should be closed 😄 ...

@win32ss win32ss closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor bug A bug that does not break the browser
Projects
None yet
Development

No branches or pull requests

4 participants