-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you save the file without specifying the extension, the downloaded file will be the same without extension (Win XP). #477
Comments
I think related to this issue with dialogs: #438 He work on this: It will be additional test case. |
Yeah, there's probably one reason for all these problems. |
Why someone wants the software to add something you dont want? if you want a extension, you write manually, this is the normal |
It is indeed expected behaviour to append the file extension in such a case in Chromium, and something I neglected when restoring the older save/open dialog boxes. I'll restore it. |
No, it is not normal, in any program in the save file dialog it is enough to specify only the file name, the extension that is specified in the "File Type" is always set automatically. |
I dont know chromium in modern systems because only have XP, but i dont have any software that append extension automatically,and i have a lot of software installed. I found a very intrusive option, since im the user, i decide name and extension Of course if is chromium default is a bug, in this case a good one! |
I decided to restore the original Chromium behaviour so the "suggested extension" will be applied in the place of no extension, but a switch will be introduced (and made permanent in chrome://flags) called --ignore-suggest-ext to keep the current behaviour. |
@TheElf01 I am pretty sure that your statement is not correct. You do have that kind of software on your computer, whether you are aware of it or not. Try it with your Notepad for example. Try saving a file called "test" (and explicitly leave out the .txt at the end). No matter whether you will set the extension-filter to Now try test2: Now try test3: Windows does offer a lot of freedom here, and offering comfort at the same time. It is very easy to miss those details. @win32ss in case of uncertainty how to properly deal with those filters from the code, the best idea is most likely to check how Chromium 49 did that for XP by having a look at the code of https://github.com/Alex313031/chromium-xp |
I verified that Chrome 49 did not append an extension when saving with "All Files". Notepad is different, but Notepad++ makes extension appending optional too. So I will revert the behaviour to the Chrome 49 behaviour. |
Fixed in 122.0.6261.152 (R4). |
Describe the bug
If you remove the extension from the file name when saving the file, the downloaded file will also be without extension. The bug exists in Win XP, but in Win 7 even if you remove the extension from the file name, the downloaded file will still have the correct extension.
To Reproduce
Click the Save link as... context menu item. (Save picture as...). Delete the suggested file name and write a new one without extension. The downloaded file will be without extension.
Expected behavior
The extension should be automatically added when you save the file.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: