Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you save the file without specifying the extension, the downloaded file will be the same without extension (Win XP). #477

Closed
EDSln opened this issue Apr 12, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@EDSln
Copy link

EDSln commented Apr 12, 2024

Describe the bug
If you remove the extension from the file name when saving the file, the downloaded file will also be without extension. The bug exists in Win XP, but in Win 7 even if you remove the extension from the file name, the downloaded file will still have the correct extension.

To Reproduce
Click the Save link as... context menu item. (Save picture as...). Delete the suggested file name and write a new one without extension. The downloaded file will be without extension.

Expected behavior
The extension should be automatically added when you save the file.

Screenshots
1
2

Desktop (please complete the following information):

  • OS: Windows XP SP3 x32
  • Supermium 122.0.6261.85 R2
  • progwrp 1.1.0.5002
@EDSln EDSln added the bug Something isn't working label Apr 12, 2024
@IDA-RE-things
Copy link

I think related to this issue with dialogs: #438

He work on this:
#438 (comment)

It will be additional test case.

@EDSln
Copy link
Author

EDSln commented Apr 12, 2024

Yeah, there's probably one reason for all these problems.

@TheElf01
Copy link

Why someone wants the software to add something you dont want? if you want a extension, you write manually, this is the normal

@win32ss
Copy link
Owner

win32ss commented Apr 12, 2024

It is indeed expected behaviour to append the file extension in such a case in Chromium, and something I neglected when restoring the older save/open dialog boxes. I'll restore it.

@EDSln
Copy link
Author

EDSln commented Apr 13, 2024

Why someone wants the software to add something you dont want? if you want a extension, you write manually, this is the normal

No, it is not normal, in any program in the save file dialog it is enough to specify only the file name, the extension that is specified in the "File Type" is always set automatically.

@TheElf01
Copy link

TheElf01 commented Apr 13, 2024

Why someone wants the software to add something you dont want? if you want a extension, you write manually, this is the normal

No, it is not normal, in any program in the save file dialog it is enough to specify only the file name, the extension that is specified in the "File Type" is always set automatically.

I dont know chromium in modern systems because only have XP, but i dont have any software that append extension automatically,and i have a lot of software installed. I found a very intrusive option, since im the user, i decide name and extension

Of course if is chromium default is a bug, in this case a good one!

@win32ss
Copy link
Owner

win32ss commented Apr 14, 2024

I decided to restore the original Chromium behaviour so the "suggested extension" will be applied in the place of no extension, but a switch will be introduced (and made permanent in chrome://flags) called --ignore-suggest-ext to keep the current behaviour.

@JoachimHenze
Copy link

JoachimHenze commented Apr 15, 2024

I dont know chromium in modern systems because only have XP, but i dont have any software that append extension automatically,and i have a lot of software installed. I found a very intrusive option, since im the user, i decide name and extension

@TheElf01 I am pretty sure that your statement is not correct. You do have that kind of software on your computer, whether you are aware of it or not. Try it with your Notepad for example. Try saving a file called "test" (and explicitly leave out the .txt at the end). No matter whether you will set the extension-filter to All files *.* or to ".txt Files". You will always get a test.txt then.
Yes, it's subtle. Yes it is unintuitive. But you had it for 23 years (of Windows XP existance) without ever realizing that (comfort)-function. And it didn't ever bother you.

Now try test2:
Notepad again. Try saving a file called "test.foo" (explicitly leave out the .txt at the end) and leave the extension-filter set to ".txt Files". You will get a "test.foo.txt" then.

Now try test3:
Notepad again. Try saving a file called "test.foo" (explicitly leave out the .txt at the end) and leave the extension-filter set to All Files *.*. You will get a "test.foo" then.

Windows does offer a lot of freedom here, and offering comfort at the same time. It is very easy to miss those details.

@win32ss in case of uncertainty how to properly deal with those filters from the code, the best idea is most likely to check how Chromium 49 did that for XP by having a look at the code of https://github.com/Alex313031/chromium-xp

@win32ss
Copy link
Owner

win32ss commented Apr 15, 2024

I am pretty sure that your statement is not correct. You do have that kind of software on your computer, whether you are aware of it or not. Try it with your Notepad for example. Try saving a file called "test" (and explicitly leave out the .txt at the end). No matter whether you will set the extension-filter to All files *.* or to ".txt Files". You will always get a test.txt then.

I verified that Chrome 49 did not append an extension when saving with "All Files". Notepad is different, but Notepad++ makes extension appending optional too.

So I will revert the behaviour to the Chrome 49 behaviour.

@EDSln
Copy link
Author

EDSln commented May 2, 2024

Fixed in 122.0.6261.152 (R4).

@EDSln EDSln closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants