Skip to content

Commit fc1c7b3

Browse files
committed
Filters could be toggled at runtime
1 parent 24e4180 commit fc1c7b3

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

http-client/src/main/java/io/micronaut/http/client/filter/HttpClientFilterResolver.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ public HttpClientFilterResolver(
9191
annotationMetadata.stringValues(Filter.class)
9292
);
9393
}).filter(entry -> {
94-
final HttpClientFilter filter = entry.httpClientFilter;
95-
if (filter instanceof Toggleable && !((Toggleable) filter).isEnabled()) {
96-
return false;
97-
}
98-
9994
boolean matches;
10095
AnnotationMetadata annotationMetadata = entry.annotationMetadata;
10196
if (annotationValue != null) {
@@ -121,6 +116,10 @@ public List<HttpClientFilter> resolveFilters(HttpRequest<?> request) {
121116
io.micronaut.http.HttpMethod method = request.getMethod();
122117
List<HttpClientFilter> filterList = new ArrayList<>(clientFilters.size());
123118
for (HttpClientFilterEntry filterEntry : clientFilters) {
119+
final HttpClientFilter filter = filterEntry.httpClientFilter;
120+
if (filter instanceof Toggleable && !((Toggleable) filter).isEnabled()) {
121+
continue;
122+
}
124123
boolean matches = true;
125124
if (filterEntry.hasMethods) {
126125
matches = anyMethodMatches(method, filterEntry.filterMethods);
@@ -130,7 +129,7 @@ public List<HttpClientFilter> resolveFilters(HttpRequest<?> request) {
130129
}
131130

132131
if (matches) {
133-
filterList.add(filterEntry.httpClientFilter);
132+
filterList.add(filter);
134133
}
135134
}
136135
return filterList;

0 commit comments

Comments
 (0)