From bb7ad60a716832124503e231723d702ac1d0e179 Mon Sep 17 00:00:00 2001 From: Will Mendes Date: Sun, 29 Nov 2020 20:41:57 +1100 Subject: [PATCH] fix: fixing types for forRoot() method --- CHANGELOG.md | 10 ++++++---- .../src/lib/ngx-skeleton-loader.module.ts | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a7b4505..c48347c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +### Fixed + +- Solving `forRoot()` types error `Generic type 'ModuleWithProviders' requires 1 type argument(s)`. Closes https://github.com/willmendesneto/ngx-skeleton-loader/issues/51 + ## [Unreleased][] ## [2.6.0][] - 2020-11-15 @@ -314,7 +318,5 @@ Now we can define the animation we want to use in `` compon [2.4.4]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.4.4 [unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.5.0...HEAD [2.5.0]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.5.0 - - -[Unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.6.0...HEAD -[2.6.0]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.6.0 \ No newline at end of file +[unreleased]: https://github.com/willmendesneto/ngx-skeleton-loader/compare/v2.6.0...HEAD +[2.6.0]: https://github.com/willmendesneto/ngx-skeleton-loader/tree/v2.6.0 diff --git a/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.module.ts b/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.module.ts index 9e28eab..c07390d 100644 --- a/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.module.ts +++ b/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.module.ts @@ -9,7 +9,7 @@ import { CommonModule } from '@angular/common'; }) export class NgxSkeletonLoaderModule { - static forRoot(): ModuleWithProviders { + static forRoot(): ModuleWithProviders { return { ngModule: NgxSkeletonLoaderModule, };