Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some external modules being interpreted as internal modules #8

Closed
sprtvln opened this issue Jun 3, 2019 · 1 comment
Closed

Some external modules being interpreted as internal modules #8

sprtvln opened this issue Jun 3, 2019 · 1 comment

Comments

@sprtvln
Copy link

sprtvln commented Jun 3, 2019

in my case it's
import { call, put, takeLatest } from 'redux-saga/effects';

this is already fixed in eslint-plugin-import
import-js/eslint-plugin-import#794
could you please fix it your package?

@willhoney7
Copy link
Owner

Hi there!

v1 of this package will move in a different direction. There will be no concept of internal/external modules. Use regexp groups instead. This will help avoid issues like this in the future. See #4. As such, I'm going to close this. v1 is code complete, just need to finish updating the tests. I'm hoping to have time to do so soon.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants