Skip to content

Commit 7955e16

Browse files
committed
Merge pull request spring-projects#33743 from msobeck
* spring-projectsgh-33743: Polish "Test Micrometer config to property exposure" Test Micrometer config to property exposure Closes spring-projectsgh-33743
2 parents df033ef + c2b43e7 commit 7955e16

24 files changed

+253
-22
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/appoptics/AppOpticsPropertiesConfigAdapterTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2020 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -30,6 +30,10 @@
3030
class AppOpticsPropertiesConfigAdapterTests
3131
extends StepRegistryPropertiesConfigAdapterTests<AppOpticsProperties, AppOpticsPropertiesConfigAdapter> {
3232

33+
AppOpticsPropertiesConfigAdapterTests() {
34+
super(AppOpticsPropertiesConfigAdapter.class);
35+
}
36+
3337
@Override
3438
protected AppOpticsProperties createProperties() {
3539
return new AppOpticsProperties();

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/atlas/AtlasPropertiesConfigAdapterTests.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,21 @@
2020

2121
import org.junit.jupiter.api.Test;
2222

23+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
24+
2325
import static org.assertj.core.api.Assertions.assertThat;
2426

2527
/**
2628
* Tests for {@link AtlasPropertiesConfigAdapter}.
2729
*
2830
* @author Mirko Sobeck
2931
*/
30-
class AtlasPropertiesConfigAdapterTests {
32+
class AtlasPropertiesConfigAdapterTests
33+
extends AbstractPropertiesConfigAdapterTests<AtlasProperties, AtlasPropertiesConfigAdapter> {
34+
35+
AtlasPropertiesConfigAdapterTests() {
36+
super(AtlasPropertiesConfigAdapter.class);
37+
}
3138

3239
@Test
3340
void whenPropertiesStepIsSetAdapterStepReturnsIt() {
@@ -116,4 +123,11 @@ void whenPropertiesEvalUriIsSetAdapterEvalUriReturnsIt() {
116123
.isEqualTo("https://atlas.example.com/evaluate");
117124
}
118125

126+
@Test
127+
@Override
128+
protected void adapterOverridesAllConfigMethods() {
129+
adapterOverridesAllConfigMethodsExcept("autoStart", "commonTags", "debugRegistry", "publisher", "rollupPolicy",
130+
"validTagCharacters");
131+
}
132+
119133
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/atlas/AtlasPropertiesTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2019 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -41,6 +41,8 @@ void defaultValuesAreConsistent() {
4141
assertThat(properties.getUri()).isEqualTo(config.uri());
4242
assertThat(properties.getMeterTimeToLive()).isEqualTo(config.meterTTL());
4343
assertThat(properties.isLwcEnabled()).isEqualTo(config.lwcEnabled());
44+
assertThat(properties.isLwcIgnorePublishStep()).isEqualTo(config.lwcIgnorePublishStep());
45+
assertThat(properties.getLwcStep()).isEqualTo(config.lwcStep());
4446
assertThat(properties.getConfigRefreshFrequency()).isEqualTo(config.configRefreshFrequency());
4547
assertThat(properties.getConfigTimeToLive()).isEqualTo(config.configTTL());
4648
assertThat(properties.getConfigUri()).isEqualTo(config.configUri());

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/datadog/DatadogPropertiesConfigAdapterTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
class DatadogPropertiesConfigAdapterTests
3232
extends StepRegistryPropertiesConfigAdapterTests<DatadogProperties, DatadogPropertiesConfigAdapter> {
3333

34+
DatadogPropertiesConfigAdapterTests() {
35+
super(DatadogPropertiesConfigAdapter.class);
36+
}
37+
3438
@Override
3539
protected DatadogProperties createProperties() {
3640
return new DatadogProperties();

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/dynatrace/DynatracePropertiesConfigAdapterTests.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import io.micrometer.dynatrace.DynatraceApiVersion;
2222
import org.junit.jupiter.api.Test;
2323

24+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
25+
2426
import static org.assertj.core.api.Assertions.assertThat;
2527

2628
/**
@@ -29,7 +31,12 @@
2931
* @author Andy Wilkinson
3032
* @author Georg Pirklbauer
3133
*/
32-
class DynatracePropertiesConfigAdapterTests {
34+
class DynatracePropertiesConfigAdapterTests
35+
extends AbstractPropertiesConfigAdapterTests<DynatraceProperties, DynatracePropertiesConfigAdapter> {
36+
37+
DynatracePropertiesConfigAdapterTests() {
38+
super(DynatracePropertiesConfigAdapter.class);
39+
}
3340

3441
@Test
3542
void whenPropertiesUriIsSetAdapterUriReturnsIt() {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/elastic/ElasticPropertiesConfigAdapterTests.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -18,14 +18,21 @@
1818

1919
import org.junit.jupiter.api.Test;
2020

21+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
22+
2123
import static org.assertj.core.api.Assertions.assertThat;
2224

2325
/**
2426
* Tests for {@link ElasticPropertiesConfigAdapter}.
2527
*
2628
* @author Andy Wilkinson
2729
*/
28-
class ElasticPropertiesConfigAdapterTests {
30+
class ElasticPropertiesConfigAdapterTests
31+
extends AbstractPropertiesConfigAdapterTests<ElasticProperties, ElasticPropertiesConfigAdapter> {
32+
33+
ElasticPropertiesConfigAdapterTests() {
34+
super(ElasticPropertiesConfigAdapter.class);
35+
}
2936

3037
@Test
3138
void whenPropertiesHostsIsSetAdapterHostsReturnsIt() {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/ganglia/GangliaPropertiesConfigAdapterTests.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,21 @@
2222
import info.ganglia.gmetric4j.gmetric.GMetric.UDPAddressingMode;
2323
import org.junit.jupiter.api.Test;
2424

25+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
26+
2527
import static org.assertj.core.api.Assertions.assertThat;
2628

2729
/**
2830
* Tests for {@link GangliaPropertiesConfigAdapter}.
2931
*
3032
* @author Mirko Sobeck
3133
*/
32-
class GangliaPropertiesConfigAdapterTests {
34+
class GangliaPropertiesConfigAdapterTests
35+
extends AbstractPropertiesConfigAdapterTests<GangliaProperties, GangliaPropertiesConfigAdapter> {
36+
37+
GangliaPropertiesConfigAdapterTests() {
38+
super(GangliaPropertiesConfigAdapter.class);
39+
}
3340

3441
@Test
3542
void whenPropertiesEnabledIsSetAdapterEnabledReturnsIt() {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/graphite/GraphitePropertiesConfigAdapterTests.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,21 @@
2222
import io.micrometer.graphite.GraphiteProtocol;
2323
import org.junit.jupiter.api.Test;
2424

25+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
26+
2527
import static org.assertj.core.api.Assertions.assertThat;
2628

2729
/**
2830
* Tests for {@link GraphitePropertiesConfigAdapter}.
2931
*
3032
* @author Mirko Sobeck
3133
*/
32-
class GraphitePropertiesConfigAdapterTests {
34+
class GraphitePropertiesConfigAdapterTests
35+
extends AbstractPropertiesConfigAdapterTests<GraphiteProperties, GraphitePropertiesConfigAdapter> {
36+
37+
GraphitePropertiesConfigAdapterTests() {
38+
super(GraphitePropertiesConfigAdapter.class);
39+
}
3340

3441
@Test
3542
void whenPropertiesEnabledIsSetAdapterEnabledReturnsIt() {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/humio/HumioPropertiesConfigAdapterTests.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,21 @@
2020

2121
import org.junit.jupiter.api.Test;
2222

23+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
24+
2325
import static org.assertj.core.api.Assertions.assertThat;
2426

2527
/**
2628
* Tests for {@link HumioPropertiesConfigAdapter}.
2729
*
2830
* @author Andy Wilkinson
2931
*/
30-
class HumioPropertiesConfigAdapterTests {
32+
class HumioPropertiesConfigAdapterTests
33+
extends AbstractPropertiesConfigAdapterTests<HumioProperties, HumioPropertiesConfigAdapter> {
34+
35+
HumioPropertiesConfigAdapterTests() {
36+
super(HumioPropertiesConfigAdapter.class);
37+
}
3138

3239
@Test
3340
void whenApiTokenIsSetAdapterApiTokenReturnsIt() {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/influx/InfluxPropertiesConfigAdapterTests.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2023 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,14 +19,21 @@
1919
import io.micrometer.influx.InfluxApiVersion;
2020
import org.junit.jupiter.api.Test;
2121

22+
import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.AbstractPropertiesConfigAdapterTests;
23+
2224
import static org.assertj.core.api.Assertions.assertThat;
2325

2426
/**
2527
* Tests for {@link InfluxPropertiesConfigAdapter}.
2628
*
2729
* @author Stephane Nicoll
2830
*/
29-
class InfluxPropertiesConfigAdapterTests {
31+
class InfluxPropertiesConfigAdapterTests
32+
extends AbstractPropertiesConfigAdapterTests<InfluxProperties, InfluxPropertiesConfigAdapter> {
33+
34+
InfluxPropertiesConfigAdapterTests() {
35+
super(InfluxPropertiesConfigAdapter.class);
36+
}
3037

3138
@Test
3239
void adaptInfluxV1BasicConfig() {

0 commit comments

Comments
 (0)